FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: mention util depth default change by BridgeAR · Pull Request #24805 · nodejs/node · GitHub

/ node Public

doc: mention util depth default change - #24805

Closed
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:revert-util-change
Closed

doc: mention util depth default change#24805
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:revert-util-change

Conversation

BridgeAR commented Dec 3, 2018

Copy link
Copy Markdown
Member

This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

Copy link
Copy Markdown
Collaborator

nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Dec 3, 2018

BridgeAR commented Dec 4, 2018

Copy link
Copy Markdown
Member Author

@nodejs/documentation PTAL

BridgeAR commented Dec 5, 2018

Copy link
Copy Markdown
Member Author

This needs another LG.

Comment thread doc/api/util.md Outdated
Co-Authored-By: BridgeAR <ruben@bridgewater.de>
BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 5, 2018

BridgeAR commented Dec 5, 2018

Copy link
Copy Markdown
Member Author

Trott commented Dec 5, 2018

Copy link
Copy Markdown
Member

Landed in 2a55e71

Trott closed this Dec 5, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2018
This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

PR-URL: nodejs#24805
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit that referenced this pull request Dec 6, 2018
This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

PR-URL: #24805
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR mentioned this pull request Dec 6, 2018
4 tasks
BridgeAR added a commit that referenced this pull request Dec 7, 2018
This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

PR-URL: #24805
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit that referenced this pull request Dec 7, 2018
This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

PR-URL: #24805
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
This was missed when reverting a former commit. To make sure the
history is kept in place, this just adds a new entry to state the
revert.

PR-URL: nodejs#24805
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR deleted the revert-util-change branch January 20, 2020 11:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL