FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix api documentation of http.createServer by aautio · Pull Request #24869 · nodejs/node · GitHub

/ node Public

doc: fix api documentation of http.createServer - #24869

Closed
aautio wants to merge 1 commit into
nodejs:v8.x-stagingfrom
aautio:issue-24105
ConversationCommits (1)ChecksFiles changed
Closed

doc: fix api documentation of http.createServer#24869
aautio wants to merge 1 commit into
nodejs:v8.x-stagingfrom
aautio:issue-24105

Conversation

aautio commented Dec 6, 2018

Copy link
Copy Markdown

Fixes: #24105

nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. v8.x labels Dec 6, 2018
aautio mentioned this pull request Dec 6, 2018
Closed

trivikr commented Dec 8, 2018

Copy link
Copy Markdown
Member

CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1864/

trivikr added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 8, 2018

Trott commented Dec 8, 2018

Copy link
Copy Markdown
Member

This needs someone from @nodejs/releasers to land it because it is on an LTS branch. /ping @BethGriggs @rvagg @MylesBorins or anyone else who can do it. Thanks!

Trott removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 8, 2018
MylesBorins pushed a commit that referenced this pull request Dec 10, 2018
doc: fix api documentation of http.createServer
6922231 
Fixes: #24105

PR-URL: #24869
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

MylesBorins commented Dec 10, 2018

Copy link
Copy Markdown
Contributor

landed in 6922231

This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL