FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: fix compiler version detection by richardlau · Pull Request #24879 · nodejs/node · GitHub

/ node Public

build: fix compiler version detection - #24879

Closed
richardlau wants to merge 2 commits into
nodejs:masterfrom
richardlau:fix_compiler_detection
ConversationCommits (2)ChecksFiles changed
Closed

build: fix compiler version detection#24879
richardlau wants to merge 2 commits into
nodejs:masterfrom
richardlau:fix_compiler_detection

Conversation

richardlau commented Dec 6, 2018

Copy link
Copy Markdown
Member

Compiler version tuples should be numeric for tuple comparisons
to work.

Before:

-bash-4.2$ gcc --version
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

-bash-4.2$ ./configure
-bash-4.2$

After:

-bash-4.2$ gcc --version
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

-bash-4.2$ ./configure
WARNING: C++ compiler too old, need g++ 4.9.4 or clang++ 3.4.2 (CXX=g++)
WARNING: warnings were emitted in the configure phase
-bash-4.2$
Checklist

build: fix compiler version detection
b11a7bb 
Compiler version tuples should be numeric for tuple comparisons
to work.

nodejs-github-bot commented Dec 6, 2018

Copy link
Copy Markdown
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1857/pipeline

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 6, 2018

richardlau commented Dec 6, 2018

Copy link
Copy Markdown
Member Author

cc @nodejs/build-files @nodejs/python

This comment has been minimized.

Sign in to view

richardlau commented Dec 6, 2018

Copy link
Copy Markdown
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/19285/

richardlau commented Dec 6, 2018

Copy link
Copy Markdown
Member Author

Also corrected the version check for AIX, which requires GCC 6.3.0 (https://github.com/nodejs/node/blob/master/BUILDING.md#aix):

-bash-4.4$ g++ --version
g++ (GCC) 4.8.4
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

-bash-4.4$ ./configure
WARNING: C++ compiler too old, need g++ 6.3.0 (CXX=g++)
WARNING: Could not recognize `gas`:
WARNING: warnings were emitted in the configure phase
-bash-4.4$

joyeecheung approved these changes Dec 6, 2018
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is happy

richardlau commented Dec 6, 2018

Copy link
Copy Markdown
Member Author

arm-fanned seems to have infra issues. Have raised nodejs/build#1626.

bnoordhuis approved these changes Dec 6, 2018
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The bug was introduced in commit 641d4a4 / PR #21183?

richardlau commented Dec 6, 2018

Copy link
Copy Markdown
Member Author

The bug was introduced in commit 641d4a4 / PR #21183?

Yes, although the previous string-based comparison was probably not quite correct either.

richardlau commented Dec 7, 2018

Copy link
Copy Markdown
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19293/

richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 7, 2018

Trott commented Dec 8, 2018

Copy link
Copy Markdown
Member

Landed in c3dd0d0

Trott closed this Dec 8, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 8, 2018
build: fix compiler version detection
c3dd0d0 
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: nodejs#24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
build: fix compiler version detection
cc8a805 
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: #24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs mentioned this pull request Dec 18, 2018
Merged
beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
build: fix compiler version detection
ebe4189 
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: nodejs#24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
build: fix compiler version detection
8d4d396 
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: #24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
build: fix compiler version detection
c0f316d 
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: #24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
build: fix compiler version detection
89f071f 
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: #24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BaochengSu pushed a commit to BaochengSu/node that referenced this pull request Oct 20, 2020
build: fix compiler version detection
0b3ba49 
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: nodejs#24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
(cherry picked from commit c3dd0d0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL