FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: split test-cli-syntax into multiple tests by Trott · Pull Request #24922 · nodejs/node · GitHub

/ node Public

test: split test-cli-syntax into multiple tests - #24922

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:divide-syntax
ConversationCommits (1)ChecksFiles changed
Closed

test: split test-cli-syntax into multiple tests#24922
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:divide-syntax

Conversation

Trott commented Dec 9, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 9, 2018

nodejs-github-bot commented Dec 9, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1877/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 9, 2018

Trott commented Dec 9, 2018

Copy link
Copy Markdown
Member Author

Refs: #24403

Trott mentioned this pull request Dec 9, 2018
Closed
Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Dec 9, 2018

Trott commented Dec 9, 2018

Copy link
Copy Markdown
Member Author

At least to see what happens, CI: https://ci.nodejs.org/job/node-test-pull-request/19357/

Trott commented Dec 9, 2018

Copy link
Copy Markdown
Member Author

With this change, it's the file-not-found test that failed in CI, which is the typical part that failed in the more monolithic version of the test. But I guess we (meaning @addaleax and perhaps some other people-who-aren't-me) already knew that it wasn't failing because of side effects.

https://ci.nodejs.org/job/node-test-commit-aix/19542/nodes=aix61-ppc64/console on test-osuosl-aix61-ppc64_be-1

10:45:19 not ok 2383 sequential/test-cli-syntax-file-not-found
10:45:19   ---
10:45:19   duration_ms: 2.6
10:45:19   severity: fail
10:45:19   exitcode: 1
10:45:19   stack: |-
10:45:19     assert.js:86
10:45:19       throw new AssertionError(obj);
10:45:19       ^
10:45:19     
10:45:19     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
10:45:19     
10:45:19     null !== 1
10:45:19     
10:45:19         at common.mustCall (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/sequential/test-cli-syntax-file-not-found.js:36:14)
10:45:19         at /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/common/index.js:346:15
10:45:19         at ChildProcess.exithandler (child_process.js:301:5)
10:45:19         at ChildProcess.emit (events.js:189:13)
10:45:19         at maybeClose (internal/child_process.js:978:16)
10:45:19         at Process.ChildProcess._handle.onexit (internal/child_process.js:265:5)
10:45:19   ...

Trott commented Dec 9, 2018

Copy link
Copy Markdown
Member Author

Oh, with this change, we can probably move some or all of these back to parallel.

Trott commented Dec 10, 2018

Copy link
Copy Markdown
Member Author

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19367/

Trott commented Dec 10, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

On Resume Build, it was test/sequential/test-cli-syntax-bad and test/sequential/test-cli-syntax-file-not-found. I was hoping splitting it up would result in the error occurring in a more consistent way, but I guess not. It's still all over the place...

Trott commented Dec 12, 2018

Copy link
Copy Markdown
Member Author

Rebased to remove conflict. Updated sequential.status. Moved tests that can now work in the parallel directory:

$ tools/test.py -j 96 --repeat 192 test/parallel/test-cli-syntax-*
[00:48|% 100|+ 576|-   0]: Done                              
$

Trott commented Dec 12, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19439/

Trott commented Dec 12, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19450/

Trott commented Dec 12, 2018

Copy link
Copy Markdown
Member Author

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19458/

Trott mentioned this pull request Dec 12, 2018
Closed

Trott commented Dec 13, 2018

Copy link
Copy Markdown
Member Author

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19469/

Trott commented Dec 13, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19471/

test: split test-cli-syntax into multiple tests
1f56568 
Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.

Move test cases back to parallel as appropriate.

Trott commented Dec 13, 2018

Copy link
Copy Markdown
Member Author

Landed in a3801e9

Trott closed this Dec 13, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 13, 2018
test: split test-cli-syntax into multiple tests
a3801e9 
Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.

Move test cases back to parallel as appropriate.

PR-URL: nodejs#24922
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
test: split test-cli-syntax into multiple tests
d366676 
Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.

Move test cases back to parallel as appropriate.

PR-URL: #24922
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
BethGriggs mentioned this pull request Dec 18, 2018
Merged
beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
test: split test-cli-syntax into multiple tests
657ede7 
Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.

Move test cases back to parallel as appropriate.

PR-URL: nodejs#24922
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
BethGriggs pushed a commit that referenced this pull request Apr 8, 2019
test: split test-cli-syntax into multiple tests
92792f0 
Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.

Move test cases back to parallel as appropriate.

PR-URL: #24922
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Trott deleted the divide-syntax branch January 13, 2022 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bengl bengl approved these changes
+1 more reviewer
apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL