FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[10.x] deps: V8: cherry-pick 52a9e67 by ofrobots · Pull Request #25027 · nodejs/node · GitHub

/ node Public

[10.x] deps: V8: cherry-pick 52a9e67 - #25027

Closed
ofrobots wants to merge 1 commit into
nodejs:v10.x-stagingfrom
ofrobots:fix/888923
ConversationCommits (1)ChecksFiles changed
Closed

[10.x] deps: V8: cherry-pick 52a9e67#25027
ofrobots wants to merge 1 commit into
nodejs:v10.x-stagingfrom
ofrobots:fix/888923

Conversation

ofrobots commented Dec 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Original commit message:

[turbofan] Fix ObjectCreate's side effect annotation.

Bug: chromium:888923
Change-Id: Ifb22cd9b34f53de3cf6e47cd92f3c0abeb10ac79
Reviewed-on: https://chromium-review.googlesource.com/1245763
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56236}

Refs: v8/v8@52a9e67

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1935/
CI: https://ci.nodejs.org/job/node-test-pull-request/19502/

nodejs-github-bot commented Dec 14, 2018

Copy link
Copy Markdown
Collaborator

@ofrobots build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1939/pipeline

nodejs-github-bot added build Issues and PRs related to build files or the CI. v10.x v8 engine Issues and PRs related to the V8 dependency. labels Dec 14, 2018
ofrobots changed the title deps: V8: cherry-pick 52a9e67 [10.x] deps: V8: cherry-pick 52a9e67 Dec 14, 2018
deps: V8: cherry-pick 52a9e67
b7a7959 
Original commit message:

    [turbofan] Fix ObjectCreate's side effect annotation.

    Bug: chromium:888923
    Change-Id: Ifb22cd9b34f53de3cf6e47cd92f3c0abeb10ac79
    Reviewed-on: https://chromium-review.googlesource.com/1245763
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#56236}

Refs: v8/v8@52a9e67

Trott commented Dec 14, 2018

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19509/

Trott commented Dec 14, 2018

Copy link
Copy Markdown
Member

Is the test-bootstrap-modules failure on CI with --worker relevant? It happened both CI runs...

ofrobots commented Dec 14, 2018

Copy link
Copy Markdown
Contributor Author

It doesn't repro on my machine. I've launched that worker job again: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/3258/.

Trott commented Dec 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

It doesn't repro on my machine. I've launched that worker job again: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/3258/.

To repro locally, you ran it with something like this?:

tools/test.py --worker parallel/test-bootstrap-modules

(The --worker flag to tools/test.py is the important bit, I think.)

ofrobots commented Dec 14, 2018

Copy link
Copy Markdown
Contributor Author

Yeah. I cannot seem to be able to reproduce this with that command, or with the command to run the whole default suite. It would be good to know if there are other environmental differences on that "freestyle" job.

Trott commented Dec 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Here it is happening on a different v10.x PR/CI run. So I think the test is just broken on v10.x-staging.

https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/3261/

@nodejs/releasers How to proceed here? Land anyway and a releaser will bisect to figure out where/when CI started failing? 😱

Trott commented Dec 14, 2018

Copy link
Copy Markdown
Member

Possibly relevant: #23876

Also: /ping @nodejs/workers

Trott mentioned this pull request Dec 14, 2018
Closed
4 tasks

ofrobots commented Dec 14, 2018

Copy link
Copy Markdown
Contributor Author

AFAICT, the test starting failing at e872089

Trott commented Dec 14, 2018

Copy link
Copy Markdown
Member

AFAICT, the test starting failing at e872089

@codebytere ^^^^^^^^^^

MylesBorins commented Dec 17, 2018

Copy link
Copy Markdown
Contributor

looks like this is a new build target. Is it failing anywhere else? cc @nodejs/build

ofrobots added a commit to ofrobots/node that referenced this pull request Dec 18, 2018
test: fix expectation in test-bootstrap-modules
16c2b54 
Ref: nodejs#25027
ofrobots mentioned this pull request Dec 18, 2018
Closed
2 tasks

ofrobots commented Dec 18, 2018

Copy link
Copy Markdown
Contributor Author

Fixing the regression in this pre-req change: #25112

MylesBorins approved these changes Dec 21, 2018
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
deps: V8: cherry-pick 52a9e67
844bd62 
Original commit message:

    [turbofan] Fix ObjectCreate's side effect annotation.

    Bug: chromium:888923
    Change-Id: Ifb22cd9b34f53de3cf6e47cd92f3c0abeb10ac79
    Reviewed-on: https://chromium-review.googlesource.com/1245763
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56236}

Refs: v8/v8@52a9e67

PR-URL: #25027
Refs: v8/v8@52a9e67
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

landed in 844bd62

MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
deps: V8: cherry-pick 52a9e67
17b55bf 
Original commit message:

    [turbofan] Fix ObjectCreate's side effect annotation.

    Bug: chromium:888923
    Change-Id: Ifb22cd9b34f53de3cf6e47cd92f3c0abeb10ac79
    Reviewed-on: https://chromium-review.googlesource.com/1245763
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56236}

Refs: v8/v8@52a9e67

PR-URL: #25027
Refs: v8/v8@52a9e67
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
codebytere mentioned this pull request Jan 4, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
MylesBorins MylesBorins approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL