FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v6.x] http: fix regression of binary upgrade response body by mcollina · Pull Request #25036 · nodejs/node · GitHub

/ node Public

[v6.x] http: fix regression of binary upgrade response body - #25036

Closed
mcollina wants to merge 1 commit into
nodejs:v6.xfrom
mcollina:6-remove-spurious-http-fix
ConversationCommits (1)ChecksFiles changed
Closed

[v6.x] http: fix regression of binary upgrade response body#25036
mcollina wants to merge 1 commit into
nodejs:v6.xfrom
mcollina:6-remove-spurious-http-fix

Conversation

mcollina commented Dec 14, 2018

Copy link
Copy Markdown
Member

See: #24958

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Dec 14, 2018

Copy link
Copy Markdown
Collaborator

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1943/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. v6.x labels Dec 14, 2018

mcollina commented Dec 14, 2018

Copy link
Copy Markdown
Member Author

cc @MylesBorins @nodejs/lts

mcollina commented Dec 14, 2018 •
edited by Trott
Loading

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19514/ ✔️

mcollina changed the title http: fix regression of binary upgrade response body [v6.x] http: fix regression of binary upgrade response body Dec 14, 2018

lpinca commented Dec 14, 2018

Copy link
Copy Markdown
Member

I think both this and #25037 can be cherry-picked from #25039 once merged no?

lpinca commented Dec 14, 2018

Copy link
Copy Markdown
Member

Ignore the above comment (#24958 (comment))

Trott mentioned this pull request Dec 14, 2018
Closed
MylesBorins approved these changes Dec 21, 2018
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
http: fix regression of binary upgrade response body
8af2553 
See: #24958

PR-URL: #25036
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

landed in 8af2553

MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
http: fix regression of binary upgrade response body
8a3e0c0 
See: #24958

PR-URL: #25036
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins mentioned this pull request Dec 21, 2018
Merged
This was referenced Dec 26, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL