win, build: fix building addons on Windows - #25108
Closed
bzoz wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Building addons would fail because addon-verify.js dependencies from tools\doc where not installed. This fixes this issue by installing those dependencies if addons are to be built. Fixes: nodejs#25096
Copy link
Copy Markdown
Collaborator
|
@bzoz build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1992/pipeline |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
cc @nodejs/platform-windows @nodejs/build-files |
Sorry, something went wrong.
BridgeAR
approved these changes
Dec 20, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Building addons would fail because addon-verify.js dependencies from tools\doc where not installed. This fixes this issue by installing those dependencies if addons are to be built. Fixes: nodejs#25096 PR-URL: nodejs#25108 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Merged
Merged
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.
Fixes: #25096
Checklist