FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: lazily load internalBinding('uv') and build the errmap lazily by joyeecheung · Pull Request #25143 · nodejs/node · GitHub

/ node Public

src: lazily load internalBinding('uv') and build the errmap lazily - #25143

Closed
joyeecheung wants to merge 2 commits into
nodejs:masterfrom
joyeecheung:uv-lazy
ConversationCommits (2)ChecksFiles changed
Closed

src: lazily load internalBinding('uv') and build the errmap lazily#25143
joyeecheung wants to merge 2 commits into
nodejs:masterfrom
joyeecheung:uv-lazy

Conversation

joyeecheung commented Dec 19, 2018

Copy link
Copy Markdown
Member

This removes the internalBinding('uv') call from the normal
bootstrap for now, and avoids building errmap by default which
expands to a lot of calls into V8.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Dec 19, 2018

Copy link
Copy Markdown
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2011/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. errors Issues and PRs related to JavaScript errors originated in Node.js core. libuv Issues and PRs related to the libuv dependency or the uv binding. util Issues and PRs related to the built-in util module. labels Dec 19, 2018

joyeecheung commented Dec 19, 2018

Copy link
Copy Markdown
Member Author

cc @addaleax

addaleax approved these changes Dec 19, 2018
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Btw, I’ve also thought about creating a static array from the macro here, instead of generating the full code for each entry… that might make things a bit easier as well?

Comment thread src/uv.cc Outdated

joyeecheung commented Dec 19, 2018

Copy link
Copy Markdown
Member Author

creating a static array from the macro here

I don't think I follow..what do you mean by creating a static array?

addaleax commented Dec 19, 2018

Copy link
Copy Markdown
Member

@joyeecheung This might not compile because I wrote it here in Github, but I think you get the idea:

static const struct {
  int value;
  const char* name;
  const char* message;
} errors[] = {
#define V(name, msg) { UV_##name, #name, msg }, 
  UV_ERRNO_MAP(V)
#undef V
  { 0, nullptr, nullptr }
};

for (const auto* error = errors; error->name != nullptr; error++) {
    Local<Value> arr[] = {
      OneByteString(isolate, error->name),
      OneByteString(isolate, error->msg)
    };
    if (err_map->Set(context,
                     Integer::New(isolate, error->value),
                     Array::New(isolate, arr, arraysize(arr))).IsEmpty()) {
      return;
    }
}

The major advantage would probably be that the code isn’t several kilobytes large in this case. No strong feelings about it, though :)

joyeecheung added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Dec 20, 2018
BridgeAR approved these changes Dec 27, 2018
View reviewed changes
Comment thread lib/internal/util.js Outdated
src: lazily load internalBinding('uv') and build the errmap lazily
c5d4f00 
This removes the `internalBinding('uv')` call from the normal
bootstrap for now, and avoids building `errmap` by default which
expands to a lot of calls into V8.
fixup! src: lazily load internalBinding('uv') and build the errmap la…
0226fe1 
…zily

joyeecheung commented Dec 28, 2018

Copy link
Copy Markdown
Member Author

Rebased and used the static struct array based the suggestion from @addaleax (thanks!), @addaleax @danbev @jasnell @BridgeAR PTAL.

CI: https://ci.nodejs.org/job/node-test-pull-request/19855/

joyeecheung added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 29, 2018

joyeecheung commented Dec 29, 2018

Copy link
Copy Markdown
Member Author

Landed in c66c073

joyeecheung added a commit that referenced this pull request Dec 29, 2018
src: lazily load internalBinding('uv') and build the errmap lazily
c66c073 
This removes the `internalBinding('uv')` call from the normal
bootstrap for now, and avoids building `errmap` by default which
expands to a lot of calls into V8.

PR-URL: #25143
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Jan 1, 2019
src: lazily load internalBinding('uv') and build the errmap lazily
dd6667d 
This removes the `internalBinding('uv')` call from the normal
bootstrap for now, and avoids building `errmap` by default which
expands to a lot of calls into V8.

PR-URL: #25143
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
src: lazily load internalBinding('uv') and build the errmap lazily
6be8888 
This removes the `internalBinding('uv')` call from the normal
bootstrap for now, and avoids building `errmap` by default which
expands to a lot of calls into V8.

PR-URL: nodejs#25143
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR mentioned this pull request Jan 16, 2019
Merged
MylesBorins mentioned this pull request Jan 24, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
BridgeAR BridgeAR approved these changes
jasnell jasnell approved these changes
+1 more reviewer
danbev danbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. errors Issues and PRs related to JavaScript errors originated in Node.js core. libuv Issues and PRs related to the libuv dependency or the uv binding. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL