util: simplify code - #25162
Closed
kkty wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Simplify code by using return value of Object.defineProperty directly.
vdeturckheim
approved these changes
Dec 21, 2018
shisama
approved these changes
Dec 22, 2018
jasnell
approved these changes
Dec 27, 2018
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tniessen
approved these changes
Dec 27, 2018
BridgeAR
approved these changes
Dec 27, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Dec 27, 2018
Simplify code by using return value of Object.defineProperty directly. PR-URL: nodejs#25162 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Copy link
Copy Markdown
Member
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Jan 1, 2019
Simplify code by using return value of Object.defineProperty directly. PR-URL: #25162 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Simplify code by using return value of Object.defineProperty directly. PR-URL: nodejs#25162 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 17, 2019
Simplify code by using return value of Object.defineProperty directly. PR-URL: #25162 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
Simplify code by using return value of Object.defineProperty directly. PR-URL: #25162 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
Simplify code by using return value of Object.defineProperty directly. PR-URL: #25162 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
Simplify code by using return value of Object.defineProperty directly. PR-URL: #25162 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify code by using return value of Object.defineProperty directly.
Checklist