FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: fix Windows shared lib build by richardlau · Pull Request #25166 · nodejs/node · GitHub

/ node Public

build: fix Windows shared lib build - #25166

Closed
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:vowels-are-important
ConversationCommits (1)ChecksFiles changed
Closed

build: fix Windows shared lib build#25166
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:vowels-are-important

Conversation

richardlau commented Dec 21, 2018

Copy link
Copy Markdown
Member

Fixes the following error running vcbuild.bat dll release openssl-no-asm:

...
  Finished generating code
  node.vcxproj -> C:\work\node\github\node\Release\\node-win.exe
  rename_node_bin_win
  'mv' is not recognized as an internal or external command,
  operable program or batch file.
C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(209,5): error MSB6006: "cmd.exe" exited with code 1. [C:\work\node\github\node\rename_node_bin_win.vcxproj]

Full build log.

cc @BethGriggs @rubys

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Dec 21, 2018

Copy link
Copy Markdown
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2026/pipeline

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 21, 2018
addaleax added the windows Issues and PRs related to the Windows platform. label Dec 21, 2018
richardlau added the shared_lib Issues and PRs related to use of Node.js as a shared library. label Dec 21, 2018

richardlau commented Dec 21, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19717/

(Note that the shared lib on Windows isn't built as part of the regular CI).

richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 21, 2018

richardlau commented Dec 21, 2018

Copy link
Copy Markdown
Member Author

https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64-gcc6/24226/testReport/junit/(root)/tes/parallel_test_fs_realpath_pipe/ failure is #25070.

richardlau commented Dec 21, 2018

Copy link
Copy Markdown
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19722/

cjihrig approved these changes Dec 21, 2018
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, and A+ branch name

richardlau commented Dec 22, 2018

Copy link
Copy Markdown
Member Author

https://ci.nodejs.org/job/node-test-commit-linux/24231/nodes=fedora-last-latest-x64/testReport/junit/(root)/test/parallel_test_trace_events_metadata/ failure is #24129.

richardlau commented Dec 22, 2018

Copy link
Copy Markdown
Member Author

Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/19737/

addaleax commented Dec 31, 2018

Copy link
Copy Markdown
Member

Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/19887/

addaleax commented Jan 2, 2019

Copy link
Copy Markdown
Member

Landed in b5239d9

addaleax closed this Jan 2, 2019
addaleax pushed a commit that referenced this pull request Jan 2, 2019
build: fix Windows shared lib build
b5239d9 
PR-URL: #25166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
bzoz mentioned this pull request Jan 2, 2019
Closed
addaleax pushed a commit that referenced this pull request Jan 5, 2019
build: fix Windows shared lib build
a2cc4ba 
PR-URL: #25166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
build: fix Windows shared lib build
a071429 
PR-URL: nodejs#25166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
build: fix Windows shared lib build
ce18bf9 
PR-URL: nodejs#25166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
build: fix Windows shared lib build
ec704a1 
PR-URL: #25166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
build: fix Windows shared lib build
3d0421a 
PR-URL: #25166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
build: fix Windows shared lib build
554a434 
PR-URL: #25166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
beevelop mentioned this pull request May 29, 2019
Closed
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
BethGriggs BethGriggs approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. shared_lib Issues and PRs related to use of Node.js as a shared library. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL