FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

improve --tls-cipher-list and TLS session resumption docs by sam-github · Pull Request #25174 · nodejs/node · GitHub

/ node Public

improve --tls-cipher-list and TLS session resumption docs - #25174

Closed
sam-github wants to merge 3 commits into
nodejs:masterfrom
sam-github:session-resumption-docs
ConversationCommits (3)ChecksFiles changed
Closed

improve --tls-cipher-list and TLS session resumption docs#25174
sam-github wants to merge 3 commits into
nodejs:masterfrom
sam-github:session-resumption-docs

Conversation

sam-github commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

While working on session resumption for TLSv1.3, I found the current session resumption docs not very useful, I hope this improves them.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Dec 21, 2018

Copy link
Copy Markdown
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2033/pipeline

nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Dec 21, 2018
sam-github force-pushed the session-resumption-docs branch from 5b0b6fc to 7a88cbd Compare December 21, 2018 22:31
mscdex reviewed Dec 21, 2018
View reviewed changes
Comment thread doc/api/tls.md Outdated
lpinca approved these changes Dec 22, 2018
View reviewed changes
Comment thread doc/api/tls.md Outdated
Comment thread doc/api/tls.md Outdated
Comment thread doc/api/tls.md Outdated

sam-github commented Dec 27, 2018

Copy link
Copy Markdown
Contributor Author

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2079/

vsemozhetbyt approved these changes Dec 27, 2018
View reviewed changes

vsemozhetbyt left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Doc format LGTM with some nits.

Comment thread doc/api/tls.md Outdated
Comment thread doc/api/tls.md Outdated
Comment thread doc/api/tls.md Outdated
Comment thread doc/api/tls.md Outdated
Comment thread doc/api/tls.md Outdated
Comment thread doc/api/tls.md Outdated
Comment thread doc/api/tls.md Outdated
Comment thread doc/api/tls.md Outdated
Comment thread doc/api/tls.md Outdated
Comment thread doc/api/tls.md Outdated
doc: link and expand --tls-cipher-list docs
5818f31 
Link to the cli docs for --tls-cipher-list, and link to and mention that
NODE_OPTIONS can also be used.
doc: describe TLS session resumption
8f27073
sam-github force-pushed the session-resumption-docs branch from 8fba640 to 8f27073 Compare December 27, 2018 19:08

sam-github commented Dec 27, 2018

Copy link
Copy Markdown
Contributor Author

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2081/

sam-github commented Dec 27, 2018

Copy link
Copy Markdown
Contributor Author

Landed in ca9c0c9...eaa1544

sam-github closed this Dec 27, 2018
sam-github deleted the session-resumption-docs branch December 27, 2018 22:32
pull Bot pushed a commit to shakir-abdo/node that referenced this pull request Dec 27, 2018
doc: link and expand --tls-cipher-list docs
b03ba38 
Link to the cli docs for --tls-cipher-list, and link to and mention that
NODE_OPTIONS can also be used.

PR-URL: nodejs#25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
pull Bot pushed a commit to shakir-abdo/node that referenced this pull request Dec 27, 2018
doc: describe TLS session resumption
eaa1544 
PR-URL: nodejs#25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos pushed a commit that referenced this pull request Jan 1, 2019
doc: link and expand --tls-cipher-list docs
3af173d 
Link to the cli docs for --tls-cipher-list, and link to and mention that
NODE_OPTIONS can also be used.

PR-URL: #25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos pushed a commit that referenced this pull request Jan 1, 2019
doc: describe TLS session resumption
e6da77b 
PR-URL: #25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
doc: link and expand --tls-cipher-list docs
6b3584b 
Link to the cli docs for --tls-cipher-list, and link to and mention that
NODE_OPTIONS can also be used.

PR-URL: nodejs#25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
doc: describe TLS session resumption
51b86ab 
PR-URL: nodejs#25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BridgeAR mentioned this pull request Jan 16, 2019
Merged
MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
doc: link and expand --tls-cipher-list docs
5438acb 
Link to the cli docs for --tls-cipher-list, and link to and mention that
NODE_OPTIONS can also be used.

PR-URL: #25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
doc: describe TLS session resumption
1a6cbdc 
PR-URL: #25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
doc: link and expand --tls-cipher-list docs
7f247fd 
Link to the cli docs for --tls-cipher-list, and link to and mention that
NODE_OPTIONS can also be used.

PR-URL: #25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
doc: describe TLS session resumption
45894d6 
PR-URL: #25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
doc: link and expand --tls-cipher-list docs
7a7c913 
Link to the cli docs for --tls-cipher-list, and link to and mention that
NODE_OPTIONS can also be used.

PR-URL: #25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs pushed a commit that referenced this pull request May 10, 2019
doc: describe TLS session resumption
63b978a 
PR-URL: #25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
doc: link and expand --tls-cipher-list docs
c84b4fb 
Link to the cli docs for --tls-cipher-list, and link to and mention that
NODE_OPTIONS can also be used.

PR-URL: #25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
doc: describe TLS session resumption
b76931b 
PR-URL: #25174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
+2 more reviewers
mscdex mscdex left review comments
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL