FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove try/catch in common.isMainThread by Trott · Pull Request #25249 · nodejs/node · GitHub

/ node Public

test: remove try/catch in common.isMainThread - #25249

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:there-is-no-try
ConversationCommits (1)ChecksFiles changed
Closed

test: remove try/catch in common.isMainThread#25249
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:there-is-no-try

Conversation

Trott commented Dec 28, 2018

Copy link
Copy Markdown
Member

Refactor common.isMainThread.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Dec 28, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2087/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 28, 2018

Trott commented Dec 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19856/ ✔️

BridgeAR reviewed Dec 28, 2018
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The code itself is LG and I like that we do not rely on throwing anymore but is this actually future proof?
As soon as workers get out of experimental they would not be loaded due to the presence of the flag anymore.

Trott commented Dec 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

As soon as workers get out of experimental they would not be loaded due to the presence of the flag anymore.

We're checking module.builtinModules. Once it's out of experimental, it will always be in that array and the else block will never be run (except on older versions of Node.js that don't have worker_threads). So, yeah, it's future proof.

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 28, 2018

Trott commented Dec 31, 2018

Copy link
Copy Markdown
Member Author

Landed in 9c2b140

Trott closed this Dec 31, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 31, 2018
test: remove try/catch in common.isMainThread
9c2b140 
Refactor common.isMainThread.

PR-URL: nodejs#25249
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jan 1, 2019
test: remove try/catch in common.isMainThread
05d1a53 
Refactor common.isMainThread.

PR-URL: #25249
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
test: remove try/catch in common.isMainThread
6140712 
Refactor common.isMainThread.

PR-URL: nodejs#25249
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR mentioned this pull request Jan 16, 2019
Merged
MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
test: remove try/catch in common.isMainThread
5634319 
Refactor common.isMainThread.

PR-URL: #25249
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
test: remove try/catch in common.isMainThread
522d8eb 
Refactor common.isMainThread.

PR-URL: #25249
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
test: remove try/catch in common.isMainThread
fcc03c1 
Refactor common.isMainThread.

PR-URL: #25249
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Trott deleted the there-is-no-try branch January 13, 2022 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL