FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove redundant fchmod test by ZYSzys · Pull Request #25282 · nodejs/node · GitHub

/ node Public

test: remove redundant fchmod test - #25282

Closed
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:test-fs-remove
ConversationCommits (1)ChecksFiles changed
Closed

test: remove redundant fchmod test#25282
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:test-fs-remove

Conversation

ZYSzys commented Dec 30, 2018

Copy link
Copy Markdown
Member

We test fs.fchmod function in test-fs-fchmod.js, so the test snippet in test-fs-chmod.js is redundant and remove it now.

node/test/parallel/test-fs-fchmod.js

Lines 10 to 20 in 903630e

// Check input type
[false, null, undefined, {}, [], ''].forEach((input) => {
const errObj = {
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
message: 'The "fd" argument must be of type number. Received type ' +
typeof input
};
assert.throws(() => fs.fchmod(input), errObj);
assert.throws(() => fs.fchmodSync(input), errObj);
});

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 30, 2018

danbev commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/19962/

addaleax commented Jan 7, 2019

Copy link
Copy Markdown
Member

Landed in ff0f99b 🎉

addaleax closed this Jan 7, 2019
addaleax pushed a commit that referenced this pull request Jan 7, 2019
test: remove redundant fchmod test
ff0f99b 
PR-URL: #25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ZYSzys deleted the test-fs-remove branch January 7, 2019 23:56
addaleax pushed a commit that referenced this pull request Jan 9, 2019
test: remove redundant fchmod test
f80fbd2 
PR-URL: #25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
test: remove redundant fchmod test
500da17 
PR-URL: nodejs#25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: remove redundant fchmod test
4d0d84e 
PR-URL: nodejs#25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
test: remove redundant fchmod test
88a5aca 
PR-URL: #25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
test: remove redundant fchmod test
294e567 
PR-URL: #25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
test: remove redundant fchmod test
26165ac 
PR-URL: #25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL