FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: split `LoadEnvironment()` at `startExecution()` by addaleax · Pull Request #25320 · nodejs/node · GitHub

/ node Public

src: split LoadEnvironment() at startExecution() - #25320

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:embedder-api
ConversationCommits (2)ChecksFiles changed
Closed

src: split LoadEnvironment() at startExecution()#25320
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:embedder-api

Conversation

addaleax commented Jan 2, 2019

Copy link
Copy Markdown
Member

This makes it easier to cater to embedders which wish to skip
the startExecution() part.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

src: split LoadEnvironment() at startExecution()
1351c49 
This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.
addaleax requested a review from joyeecheung January 2, 2019 23:20

nodejs-github-bot commented Jan 2, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2129/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 2, 2019
joyeecheung approved these changes Jan 3, 2019
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. I wonder if as a follow up we should put the JS land startExecution into a separate file..

bnoordhuis approved these changes Jan 3, 2019
View reviewed changes
Comment thread src/node.cc Outdated
Comment thread src/node.cc
if (start_execution.IsEmpty()) return;
start_execution->Call(
env->context(), Undefined(env->isolate()), 0, nullptr);
env->set_start_execution_function(Local<Function>());

bnoordhuis Jan 3, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe do this before the call to, er, Call() as an extra guard against recursive invocation?

addaleax Jan 3, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done, but it requires some extra magic because of the way the env->...() getters work…

addaleax commented Jan 5, 2019

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19947/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 5, 2019

addaleax commented Jan 6, 2019

Copy link
Copy Markdown
Member Author

Landed in f6a1d88

addaleax closed this Jan 6, 2019
addaleax deleted the embedder-api branch January 6, 2019 01:16
addaleax added a commit that referenced this pull request Jan 6, 2019
src: split LoadEnvironment() at startExecution()
f6a1d88 
This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.

PR-URL: #25320
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
kkty mentioned this pull request Jan 8, 2019
Closed
2 tasks
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
src: split LoadEnvironment() at startExecution()
26c626b 
This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.

PR-URL: nodejs#25320
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
addaleax added a commit that referenced this pull request Jan 15, 2019
src: split LoadEnvironment() at startExecution()
21096f9 
This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.

PR-URL: #25320
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
src: split LoadEnvironment() at startExecution()
e0d2fb3 
This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.

PR-URL: nodejs#25320
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
src: split LoadEnvironment() at startExecution()
6cdaf03 
This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.

PR-URL: nodejs#25320
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins mentioned this pull request Jan 24, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
joyeecheung joyeecheung approved these changes
JungMinu JungMinu approved these changes
+1 more reviewer
fhinkel fhinkel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL