FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove unused isolate variable by danbev · Pull Request #25368 · nodejs/node · GitHub

/ node Public

src: remove unused isolate variable - #25368

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:node_task_unused_var
ConversationCommits (1)ChecksFiles changed
Closed

src: remove unused isolate variable#25368
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:node_task_unused_var

Conversation

danbev commented Jan 6, 2019

Copy link
Copy Markdown
Contributor

Currently the following compiler warning is generated:

../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

src: remove unused isolate variable
5061bdf 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

nodejs-github-bot commented Jan 6, 2019

Copy link
Copy Markdown
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2154/pipeline

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 6, 2019

danbev commented Jan 6, 2019

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19955/

cjihrig commented Jan 6, 2019

Copy link
Copy Markdown
Contributor

FWIW, I'm in favor of fast tracking trivial compiler warning fixes like this one.

danbev added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 6, 2019

danbev commented Jan 6, 2019

Copy link
Copy Markdown
Contributor Author

Please +1 for fast tracking.

addaleax commented Jan 6, 2019

Copy link
Copy Markdown
Member

Landed in 398916a

addaleax closed this Jan 6, 2019
addaleax pushed a commit that referenced this pull request Jan 6, 2019
src: remove unused isolate variable
398916a 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

PR-URL: #25368
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danbev deleted the node_task_unused_var branch January 7, 2019 04:42

starkwang commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

This change seems no need to be backported. The removed isolate variable is being used in here:

node/src/bootstrapper.cc

Lines 113 to 129 in 7d46437

void SetupPromises(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
Isolate* isolate = env->isolate();
CHECK(args[0]->IsFunction());
CHECK(args[1]->IsObject());
Local<Object> constants = args[1].As<Object>();
NODE_DEFINE_CONSTANT(constants, kPromiseRejectWithNoHandler);
NODE_DEFINE_CONSTANT(constants, kPromiseHandlerAddedAfterReject);
NODE_DEFINE_CONSTANT(constants, kPromiseResolveAfterResolved);
NODE_DEFINE_CONSTANT(constants, kPromiseRejectAfterResolved);
isolate->SetPromiseRejectCallback(PromiseRejectCallback);
env->set_promise_handler_function(args[0].As<Function>());
}

refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
src: remove unused isolate variable
734e482 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

PR-URL: nodejs#25368
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jan 15, 2019
src: remove unused isolate variable
497a08a 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

PR-URL: #25368
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
src: remove unused isolate variable
7bb31bd 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

PR-URL: nodejs#25368
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
src: remove unused isolate variable
81924ff 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

PR-URL: nodejs#25368
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Jan 24, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL