FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc,worker_threads: revise worker_threads.md by Trott · Pull Request #25402 · nodejs/node · GitHub

/ node Public

doc,worker_threads: revise worker_threads.md - #25402

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:revise-worker-threads-doc
Closed

doc,worker_threads: revise worker_threads.md#25402
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:revise-worker-threads-doc

Conversation

Trott commented Jan 8, 2019

Copy link
Copy Markdown
Member

Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Copy link
Copy Markdown
Collaborator

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 8, 2019
Comment thread doc/api/worker_threads.md Outdated
Comment thread doc/api/worker_threads.md Outdated
Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.
Trott force-pushed the revise-worker-threads-doc branch from a13e303 to 3bd05fb Compare January 9, 2019 03:01

Trott commented Jan 9, 2019

Copy link
Copy Markdown
Member Author

Rebased, updated based on nits, force-pushed.

Trott commented Jan 9, 2019

Copy link
Copy Markdown
Member Author

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 9, 2019

Trott commented Jan 11, 2019

Copy link
Copy Markdown
Member Author

Landed in 1415d57

Trott closed this Jan 11, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jan 11, 2019
Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

PR-URL: nodejs#25402
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

PR-URL: #25402
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR mentioned this pull request Jan 16, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

PR-URL: nodejs#25402
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Jan 24, 2019
Trott deleted the revise-worker-threads-doc branch January 13, 2022 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL