doc: os.networkInterfaces() example outdated - #25417
Closed
jvelezpo wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The os.networkInterfaces() example was outdated as the IPv6 interfaces did not include the scopeid property, now they do. Fixes: #25408
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
BridgeAR
approved these changes
Jan 10, 2019
starkwang
approved these changes
Jan 11, 2019
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
The os.networkInterfaces() example was outdated as the IPv6 interfaces did not include the scopeid property, now they do. PR-URL: nodejs#25417 Fixes: nodejs#25408 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Weijia Wang <starkwang@126.com>
Merged
Merged
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.
Fixes: #25408
Checklist