test,worker_threads: simplify common.isMainThread - #25426
Conversation
Sorry, something went wrong.
Now that `worker_threads` do not require a flag, the logic around loading `isMainThread` can be removed.
|
@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2215/pipeline |
Sorry, something went wrong.
Sorry, something went wrong.
|
Is there a case for removing this from common entirely now and directly calling require('worker_threads').isMainThread from the tests? |
Sorry, something went wrong.
@richardlau Yes, probably, but that will be a larger change with more churn that will be more likely to have merge conflicts on backporting etc. So I was thinking: Do this narrower change first. |
Sorry, something went wrong.
Now that `worker_threads` do not require a flag, the logic around loading `isMainThread` can be removed. PR-URL: nodejs#25426 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Now that `worker_threads` do not require a flag, the logic around loading `isMainThread` can be removed. PR-URL: #25426 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Now that `worker_threads` do not require a flag, the logic around loading `isMainThread` can be removed. PR-URL: nodejs#25426 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Now that worker_threads do not require a flag, the logic around
loading isMainThread can be removed.
Checklist