build,test: fail coverage target if tests fail - #25432
Closed
refack wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2220/pipeline |
Sorry, something went wrong.
lpinca
approved these changes
Jan 10, 2019
mhdawson
approved these changes
Jan 10, 2019
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM we can easily back out if this does not agree with the coverage CI.
Sorry, something went wrong.
pull Bot
pushed a commit
to shakir-abdo/node
that referenced
this pull request
Jan 15, 2019
PR-URL: nodejs#25432 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 15, 2019
PR-URL: #25432 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
PR-URL: nodejs#25432 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Copy link
Copy Markdown
Member
|
Due to the recent failures and the request not to add this to the v11.7.0 release I marked this as don't land. |
Sorry, something went wrong.
2 tasks
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fix for #24966
Make the coverage-test target fail if running the tests fail. This way we get early warning that something is borked and we don't publish spurious results.
/CC @nodejs/build-files @nodejs/benchmarking @nodejs/testing
Checklist