FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove unused uncaughtException handler by addaleax · Pull Request #25641 · nodejs/node · GitHub

/ node Public

test: remove unused uncaughtException handler - #25641

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:test-tty-stdout-end
ConversationCommits (2)ChecksFiles changed
Closed

test: remove unused uncaughtException handler#25641
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:test-tty-stdout-end

Conversation

addaleax commented Jan 22, 2019

Copy link
Copy Markdown
Member

This has been unused since cbc3ef6.

Refs: #23053

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot commented Jan 22, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2341/pipeline

nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Jan 22, 2019
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 24, 2019

addaleax commented Jan 24, 2019

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20304/

richardlau reviewed Jan 25, 2019
View reviewed changes
Comment thread test/pseudo-tty/test-tty-stdout-end.js Outdated
richardlau removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 25, 2019
mhdawson approved these changes Jan 25, 2019
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

fixup! test: remove unused uncaughtException handler
5067d20 
Co-Authored-By: addaleax <github@addaleax.net>

addaleax commented Jan 27, 2019

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20351/

addaleax commented Jan 27, 2019

Copy link
Copy Markdown
Member Author

Landed in 573ec5b

addaleax closed this Jan 27, 2019
addaleax deleted the test-tty-stdout-end branch January 27, 2019 19:46
addaleax added a commit that referenced this pull request Jan 27, 2019
test: remove unused uncaughtException handler
573ec5b 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax added a commit that referenced this pull request Jan 28, 2019
test: remove unused uncaughtException handler
7d68223 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos mentioned this pull request Jan 29, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
test: remove unused uncaughtException handler
1eb38b0 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
test: remove unused uncaughtException handler
802661a 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
test: remove unused uncaughtException handler
48505d8 
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau left review comments
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
Fishrock123 Fishrock123 approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL