FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v8.x-backport] n-api: mark thread-safe function as stable by gabrielschulhof · Pull Request #25648 · nodejs/node · GitHub

/ node Public

[v8.x-backport] n-api: mark thread-safe function as stable - #25648

Closed
gabrielschulhof wants to merge 2 commits into
nodejs:v8.x-stagingfrom
gabrielschulhof:un-experimental-tsfn-v8.x
ConversationCommits (2)ChecksFiles changed
Closed

[v8.x-backport] n-api: mark thread-safe function as stable#25648
gabrielschulhof wants to merge 2 commits into
nodejs:v8.x-stagingfrom
gabrielschulhof:un-experimental-tsfn-v8.x

Conversation

gabrielschulhof commented Jan 22, 2019

Copy link
Copy Markdown
Contributor

Remove NAPI_EXPERIMENTAL guard from around N-API thread-safe function
APIs.

Unlike in later versions of Node.js in this version the NAPI_EXPERIMENTAL guard cannot be replaced with #if NAPI_VERSION >= 4 because the N-API versioning commit (8476053) was not backported. So, the only option is to drop the guard.

Fixes: #24249
PR-URL: #25556

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Jan 22, 2019

Copy link
Copy Markdown
Collaborator

@gabrielschulhof build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2345/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. v8.x labels Jan 22, 2019
gabrielschulhof force-pushed the un-experimental-tsfn-v8.x branch from d4728e7 to ca8a70e Compare January 22, 2019 22:31
gabrielschulhof added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 22, 2019
mhdawson reviewed Jan 23, 2019
View reviewed changes
Comment thread src/node_api.h Outdated
gabrielschulhof force-pushed the un-experimental-tsfn-v8.x branch from ca8a70e to 94a1637 Compare January 25, 2019 19:24
gabrielschulhof changed the title n-api: mark thread-safe function as stable [v8.x-backport] n-api: mark thread-safe function as stable Jan 25, 2019

gabrielschulhof commented Jan 25, 2019

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20326/

gabrielschulhof commented Jan 25, 2019

Copy link
Copy Markdown
Contributor Author

@mhdawson I have now backported the commit that introduces the guards.

gabrielschulhof mentioned this pull request Jan 28, 2019
Closed
mhdawson reviewed Jan 28, 2019
View reviewed changes
Comment thread doc/api/n-api.md Outdated

mhdawson Jan 28, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As an aside do we need to update this table, at least in master?

gabrielschulhof Jan 29, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, I think we do.

gabrielschulhof Jan 29, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

#25801

mhdawson approved these changes Jan 28, 2019
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

gabrielschulhof mentioned this pull request Feb 21, 2019
Closed
kfarnung and others added 2 commits March 4, 2019 10:29
n-api: restrict exports by version
80fa044 
* Move `napi_get_uv_event_loop` into the `NAPI_VERSION >= 2` section
* Move `napi_open_callback_scope`, `napi_close_callback_scope`,
  `napi_fatal_exception`, `napi_add_env_cleanup_hook`, and
  `napi_remove_env_cleanup_hook` into the `NAPI_VERSION >= 3` section
* Added a missing `added` property to `napi_get_uv_event_loop` in the
  docs
* Added a `napiVersion` property to the docs and updated the parser and
  generator to use it.
* Added usage documentation

PR-URL: nodejs#19962
Backport-PR-URL: nodejs#25648
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
n-api: mark thread-safe function as stable
ad9c154 
Fixes: nodejs#24249
PR-URL: nodejs#25556
Backport-PR-URL: nodejs#25633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gabrielschulhof force-pushed the un-experimental-tsfn-v8.x branch from 94a1637 to ad9c154 Compare March 4, 2019 18:29

gabrielschulhof commented Mar 4, 2019

Copy link
Copy Markdown
Contributor Author

Weird ... github said there was a conflict in 4 different files, but I rebased and there was no conflict at all.

gabrielschulhof commented Mar 8, 2019

Copy link
Copy Markdown
Contributor Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/21342/

gabrielschulhof commented Mar 8, 2019

Copy link
Copy Markdown
Contributor Author

Resumed as: https://ci.nodejs.org/job/node-test-pull-request/21346/

gabrielschulhof mentioned this pull request Mar 19, 2019
Closed
BethGriggs pushed a commit that referenced this pull request Mar 20, 2019
n-api: restrict exports by version
44609d1 
* Move `napi_get_uv_event_loop` into the `NAPI_VERSION >= 2` section
* Move `napi_open_callback_scope`, `napi_close_callback_scope`,
  `napi_fatal_exception`, `napi_add_env_cleanup_hook`, and
  `napi_remove_env_cleanup_hook` into the `NAPI_VERSION >= 3` section
* Added a missing `added` property to `napi_get_uv_event_loop` in the
  docs
* Added a `napiVersion` property to the docs and updated the parser and
  generator to use it.
* Added usage documentation

PR-URL: #19962
Backport-PR-URL: #25648
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs pushed a commit that referenced this pull request Mar 20, 2019
n-api: mark thread-safe function as stable
d6ffabc 
Fixes: #24249
PR-URL: #25556
Backport-PR-URL: #25648
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BethGriggs commented Mar 20, 2019

Copy link
Copy Markdown
Member

Landed on v8.x-staging

BethGriggs closed this Mar 20, 2019
gabrielschulhof deleted the un-experimental-tsfn-v8.x branch June 14, 2019 23:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL