FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Refactor mac installer (Rebase of #776 against master) by fhemberger · Pull Request #2571 · nodejs/node · GitHub

/ node Public

Refactor mac installer (Rebase of #776 against master) - #2571

Closed
fhemberger wants to merge 1 commit into
nodejs:masterfrom
fhemberger:refactor-mac-installer-rebase
ConversationCommits (1)ChecksFiles changed
Closed

Refactor mac installer (Rebase of #776 against master)#2571
fhemberger wants to merge 1 commit into
nodejs:masterfrom
fhemberger:refactor-mac-installer-rebase

Conversation

fhemberger commented Aug 27, 2015

Copy link
Copy Markdown
Contributor

Can you please check, if the Mac installer is built and working correctly?

fhemberger mentioned this pull request Aug 27, 2015
Closed
brendanashworth added install Issues and PRs related to the installers. macos Issues and PRs related to the macOS platform / OSX. labels Aug 27, 2015

pmq20 commented Aug 27, 2015

Copy link
Copy Markdown
Contributor

Given that tools/osx-pkg.pmdoc/index.xml.tmpl has been deleted, why Makefile still has a line [1] read cat tools/osx-pkg.pmdoc/index.xml.tmpl?

[1] https://github.com/fhemberger/node/blob/refactor-mac-installer-rebase/Makefile#L351

fhemberger commented Aug 27, 2015

Copy link
Copy Markdown
Contributor Author

Because I forgot to remove it. ;) Good catch, thanks!

remixz reviewed Aug 27, 2015
View reviewed changes
Comment thread Makefile Outdated

remixz Aug 27, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This needs to be changed to touch tools/osx-pkg/scripts/nodejs-run-uninstall

remixz commented Aug 27, 2015

Copy link
Copy Markdown
Contributor

With the couple of changes I noted on the files, this builds! 🎉 This is great, cheers to you @fhemberger. I had tried to rebase it a little while ago, but I unfortunately didn't get far. I'm very glad you did. 😄

fhemberger commented Aug 28, 2015

Copy link
Copy Markdown
Contributor Author

@remixz Phew, I'm glad it worked out. Thanks for your help!

Fishrock123 commented Aug 28, 2015

Copy link
Copy Markdown
Contributor

Linking: #776

silverwind commented Sep 8, 2015

Copy link
Copy Markdown
Contributor

Very minor issue with the current installer: The logo is not scaled properly and is telling me 'No' :)

fhemberger commented Sep 8, 2015

Copy link
Copy Markdown
Contributor Author

For the sidebar, I think we should go with a colored version oft the hexagon, instead of scaling the logo down. What do you think?

silverwind commented Sep 8, 2015

Copy link
Copy Markdown
Contributor

👍 would make better use of the available space than the scaled logo.

fhemberger commented Sep 9, 2015

Copy link
Copy Markdown
Contributor Author

Can someone please confirm that the rebased version is building correctly?
Also updated the installer logo:

fhemberger commented Sep 20, 2015

Copy link
Copy Markdown
Contributor Author

@nodejs/build Can we please merge this? Various incarnations of this PR have been open for months now, and I'd like to get this done, so we can start with the actual translation work (same for the Windows installer).

rvagg commented Sep 21, 2015

Copy link
Copy Markdown
Member

yes, but no, needs changes on the build machines so requires some additional work and testing, non-trivial merge, I'm sorry that I'm currently holding this one up, I'll (a) be trying to get to this as soon as I can and (b) removing myself as a bottleneck as we get more of the build team access to the osx machines

fhemberger commented Oct 14, 2015

Copy link
Copy Markdown
Contributor Author

< insert (almost) monthly nag here > 😄

As v5 seems to be already waiting around the corner, it would be great if this could land as well.

jasnell commented Oct 14, 2015

Copy link
Copy Markdown
Member

Does this supersede / replace #776?

silverwind commented Oct 14, 2015

Copy link
Copy Markdown
Contributor

@fhemberger can you provide some build instructions for the installer, so I can test it?

fhemberger commented Oct 15, 2015

Copy link
Copy Markdown
Contributor Author

@jasnell Yes, it's the changes of #776 rebased against the current master.

@silverwind Install Packages, then build for OS X:

./configure
make
make pre-pkg
make install DESTDIR=out/dist-osx
/usr/local/bin/packagesbuild tools/osx-pkg/osx-pkg-out.pkgproj

silverwind commented Oct 15, 2015

Copy link
Copy Markdown
Contributor

Gave it a few installs/uninstalls and it looks to be working great. Only nag I have is that it says 'Node.js was installed' after uninstalling. Other than that, LGTM.

rvagg added this to the 5.0.0 milestone Oct 16, 2015
rvagg mentioned this pull request Oct 16, 2015
Closed
13 tasks

evanlucas commented Oct 22, 2015

Copy link
Copy Markdown
Contributor

The current packages are named node-vx.x.x.pkg. This changes that to nodejs-vx.x.x.pkg. I would think that could break some external tools maybe?

silverwind commented Oct 22, 2015

Copy link
Copy Markdown
Contributor

Should be the node scheme: https://nodejs.org/dist/v4.2.1/

fhemberger commented Oct 23, 2015

Copy link
Copy Markdown
Contributor Author

@evanlucas Good catch, fixed.

evanlucas reviewed Oct 23, 2015
View reviewed changes
Comment thread tools/osx-pkg/scripts/uninstall.sh Outdated

evanlucas Oct 23, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

what happens if it was installed to a custom location?

fhemberger Oct 23, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You can't choose a custom location in the installer.

Sorry, the screenshot is German but you get the idea.

evanlucas Oct 23, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ah good point

evanlucas commented Oct 23, 2015

Copy link
Copy Markdown
Contributor

Do we have a retina image available for the sidebar? I wonder if packages even supports that. If so, we should probably add that.

This seems to work well. @rvagg if there is anything I can do to help on the build side of things to get this in for v5.0.0, feel free to let me know :] Overall, LGTM for whenever this can land.

jbergstroem commented Oct 23, 2015

Copy link
Copy Markdown
Member

@evanlucas mac installers surely must be able to render a svg, no?

jpwesselink added a commit to jpwesselink/node that referenced this pull request Sep 15, 2017
tools, build: macOS installer
bf9157f 
Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm

PR-URL: nodejs#15179
Fixes: nodejs#15012
Refs: nodejs#5656
Refs: nodejs#2571
Refs: nodejs#7097
BridgeAR pushed a commit that referenced this pull request Sep 28, 2017
tools, build: refactor macOS installer
03954f7 
Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
tools, build: refactor macOS installer
803d9c1 
Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
tools, build: refactor macOS installer
29a3b3a 
Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: nodejs/node#15179
Fixes: nodejs/node#15012
Refs: nodejs/node#5656
Refs: nodejs/node#2571
Refs: nodejs/node#7097
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
tools, build: refactor macOS installer
7e8c0fd 
Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
tools, build: refactor macOS installer
eebb2d7 
Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2018
tools, build: refactor macOS installer
2400fc2 
Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 17, 2018
tools, build: refactor macOS installer
23ad5cb 
Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
tools, build: refactor macOS installer
7bab6bc 
Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
tools, build: refactor macOS installer
3a12b46 
Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
tools, build: refactor macOS installer
18803bc 
Creates macOS pkg installer by using `pkgbuild` and `productbuild`.
Removes previous npm installation before installing npm.
Packages carry correct version attributes.
Support for intl installer features, defaults to `en`.
Fancy formatted license.
Renamed `osx` references to `macOS`.
Optional installation of npm.

PR-URL: #15179
Fixes: #15012
Refs: #5656
Refs: #2571
Refs: #7097
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
solebox mentioned this pull request Nov 27, 2023
Open
s4sc mentioned this pull request Nov 28, 2023
Open
enterstudio mentioned this pull request Nov 29, 2023
Open
This was referenced Mar 29, 2024
Open
Open
Open
Open
Open
This was referenced Mar 30, 2024
Open
Open
Open
This was referenced Mar 30, 2024
Open
Open
snyk-io Bot mentioned this pull request Oct 21, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

install Issues and PRs related to the installers. macos Issues and PRs related to the macOS platform / OSX.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL