[v8.x-backport] build: skip cctest on Windows shared lib build - #25758
Closed
BethGriggs wants to merge 1 commit into
Closed
[v8.x-backport] build: skip cctest on Windows shared lib build#25758BethGriggs wants to merge 1 commit into
BethGriggs wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
richardlau
approved these changes
Jan 28, 2019
BethGriggs
force-pushed
the
backport-21228-to-v8.x
branch
from
54fb748 to
0362dae
Compare
March 20, 2019 13:08
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
refack
approved these changes
Mar 20, 2019
cctest depends on some internal APIs which don't declare `__declspec(dllexport)` and causes build failure when building node as shared lib on Windows. Since we already have good test coverage in static lib, we decide to skip the cctest in shared lib build on Windows. Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: nodejs#21228 Reviewed-By: Refael Ackermann <refack@gmail.com>
BethGriggs
force-pushed
the
backport-21228-to-v8.x
branch
from
0362dae to
e1967a2
Compare
March 20, 2019 22:05
BethGriggs
pushed a commit
that referenced
this pull request
Mar 20, 2019
cctest depends on some internal APIs which don't declare `__declspec(dllexport)` and causes build failure when building node as shared lib on Windows. Since we already have good test coverage in static lib, we decide to skip the cctest in shared lib build on Windows. Signed-off-by: Yihong Wang <yh.wang@ibm.com> Backport-PR-URL: #25758 PR-URL: #21228 Reviewed-By: Refael Ackermann <refack@gmail.com>
Copy link
Copy Markdown
Member
Author
|
Landed on v8.x-staging |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport to resolve simple conflict and to ensure this change makes it into v8.x.
cctest depends on some internal APIs which don't declare
__declspec(dllexport) and causes build failure when building
node as shared lib on Windows. Since we already have good test
coverage in static lib, we decide to skip the cctest in shared
lib build on Windows.
Signed-off-by: Yihong Wang yh.wang@ibm.com
PR-URL: #21228
Reviewed-By: Refael Ackermann refack@gmail.com
Checklist