FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

events: onceWrapper returns target value by himself65 · Pull Request #25818 · nodejs/node · GitHub

/ node Public

events: onceWrapper returns target value - #25818

Closed
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:master
ConversationCommits (1)ChecksFiles changed
Closed

events: onceWrapper returns target value#25818
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:master

Conversation

himself65 commented Jan 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the events Issues and PRs related to the events subsystem / EventEmitter. label Jan 30, 2019
himself65 mentioned this pull request Jan 30, 2019
Closed
himself65 closed this Jan 31, 2019
himself65 reopened this Feb 2, 2019
bnoordhuis reviewed Feb 4, 2019
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add one or more regression tests?

himself65 commented Feb 4, 2019

Copy link
Copy Markdown
Member Author

Can you add one or more regression tests?

I will try that

himself65 commented Feb 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

@bnoordhuis added

And my computer so slow, I can't do a local test 😥

lpinca approved these changes Feb 9, 2019
View reviewed changes
Comment thread test/parallel/test-event-emitter-listeners.js Outdated
Comment thread test/parallel/test-event-emitter-listeners.js Outdated

lpinca commented Feb 9, 2019

Copy link
Copy Markdown
Member

@himself65 subsystem in commit message should be events: not src:.

lpinca commented Feb 9, 2019

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20680/

himself65 changed the title src: events onceWrapper returns target value events: onceWrapper returns target value Feb 9, 2019

lpinca commented Mar 4, 2019

Copy link
Copy Markdown
Member

Fixes: #25817
New CI: https://ci.nodejs.org/job/node-test-pull-request/21186/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 4, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 5, 2019
events: onceWrapper returns target value
acc506c 
PR-URL: nodejs#25818
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

BridgeAR commented Mar 5, 2019

Copy link
Copy Markdown
Member

Landed in acc506c

@himself65 congratulations on your first commit to Node.js! 🎉

BridgeAR closed this Mar 5, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
events: onceWrapper returns target value
83fba1e 
PR-URL: nodejs#25818
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR mentioned this pull request Mar 13, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
events: onceWrapper returns target value
cb0fc65 
PR-URL: #25818
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis left review comments
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL