win, build: add arbitrary MSBuild flag option and binlog option - #25994
Closed
jkunkee wants to merge 1 commit into
Closed
win, build: add arbitrary MSBuild flag option and binlog option#25994jkunkee wants to merge 1 commit into
jkunkee wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jkunkee
force-pushed
the
win-build-script-tweaks
branch
from
94eea9a to
623ec64
Compare
February 7, 2019 20:46
refack
suggested changes
Feb 7, 2019
Comment thread
vcbuild.bat
Outdated
Copy link
Copy Markdown
Contributor
|
Hello @jkunkee I like the idea behind the proposed change, but I think we can do it with a simpler, more generic way 🤷♂️. P.S. If you have any questions you can also feel free to contact me directly. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
/CC @nodejs/build-files @nodejs/platform-windows |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the welcome and the review! I've reread the contributor and PR guides and will email you soon. |
Sorry, something went wrong.
jkunkee
force-pushed
the
win-build-script-tweaks
branch
2 times, most recently
from
4bed141 to
490f726
Compare
February 9, 2019 18:31
refack
reviewed
Feb 9, 2019
Comment thread
vcbuild.bat
Outdated
jkunkee
force-pushed
the
win-build-script-tweaks
branch
2 times, most recently
from
4edce07 to
cf0681c
Compare
February 9, 2019 23:59
Copy link
Copy Markdown
Contributor
Author
|
Note new commit message (cf0681c) |
Sorry, something went wrong.
joaocgreis
approved these changes
Feb 13, 2019
Copy link
Copy Markdown
Member
|
CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/20750/ ❌ (arm-fanned) @refack does your request for changes still hold? |
Sorry, something went wrong.
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used to pass arbitrary flags to MSBuild. It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to enable binary logging to `%config%\node.binlog`. This is especially convenient when debugging changes to the build system. In the process of developing this change, the idea of adding 'setlocal' to the beginning of the script was rejected since other scripts in this repo rely on the exported environment variables. This change adds a note describing this.
jkunkee
force-pushed
the
win-build-script-tweaks
branch
from
cf0681c to
11b5a48
Compare
February 20, 2019 22:07
Copy link
Copy Markdown
Member
|
@refack I believe your feedback has been addressed, I'll assume there's no problem with landing this. CI: https://ci.nodejs.org/job/node-test-pull-request/21182/ ✔️ |
Sorry, something went wrong.
joaocgreis
pushed a commit
that referenced
this pull request
Mar 4, 2019
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used to pass arbitrary flags to MSBuild. It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to enable binary logging to `%config%\node.binlog`. This is especially convenient when debugging changes to the build system. In the process of developing this change, the idea of adding 'setlocal' to the beginning of the script was rejected since other scripts in this repo rely on the exported environment variables. This change adds a note describing this. PR-URL: #25994 Reviewed-By: João Reis <reis@janeasystems.com>
Copy link
Copy Markdown
Member
Sorry, something went wrong.
3 tasks
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 6, 2019
PR-URL: nodejs#26431 Refs: nodejs#25994 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used to pass arbitrary flags to MSBuild. It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to enable binary logging to `%config%\node.binlog`. This is especially convenient when debugging changes to the build system. In the process of developing this change, the idea of adding 'setlocal' to the beginning of the script was rejected since other scripts in this repo rely on the exported environment variables. This change adds a note describing this. PR-URL: nodejs#25994 Reviewed-By: João Reis <reis@janeasystems.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
PR-URL: nodejs#26431 Refs: nodejs#25994 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used to pass arbitrary flags to MSBuild. It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to enable binary logging to `%config%\node.binlog`. This is especially convenient when debugging changes to the build system. In the process of developing this change, the idea of adding 'setlocal' to the beginning of the script was rejected since other scripts in this repo rely on the exported environment variables. This change adds a note describing this. PR-URL: #25994 Reviewed-By: João Reis <reis@janeasystems.com>
Merged
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a 'verbose' flag to vcbuild.bat that turns on outputs
useful for build debugging, including MSBuild BinLogging and
DEBUG_HELPER logging.
It also adds a 'setlocal' call so internal environment variables no
longer leak out to the calling shell.
Checklist
[Edit: Note new commit message (cf0681c)]