FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: extract common sockaddr creation code by danbev · Pull Request #26070 · nodejs/node · GitHub

/ node Public

src: extract common sockaddr creation code - #26070

Closed
danbev wants to merge 4 commits into
nodejs:masterfrom
danbev:udp_sockaddr
ConversationCommits (4)ChecksFiles changed
Closed

src: extract common sockaddr creation code#26070
danbev wants to merge 4 commits into
nodejs:masterfrom
danbev:udp_sockaddr

Conversation

danbev commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

src: extract common sockaddr creation code
db1028c 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

nodejs-github-bot commented Feb 13, 2019

Copy link
Copy Markdown
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2590/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. labels Feb 13, 2019

danbev commented Feb 13, 2019

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20758/

danbev added the wip Issues and PRs that are still a work in progress. label Feb 13, 2019
addaleax reviewed Feb 13, 2019
View reviewed changes
Comment thread src/udp_wrap.cc Outdated

danbev commented Feb 13, 2019

Copy link
Copy Markdown
Contributor Author

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/20759/

addaleax approved these changes Feb 13, 2019
View reviewed changes
Comment thread src/udp_wrap.cc Outdated
danbev removed the wip Issues and PRs that are still a work in progress. label Feb 14, 2019
richardlau reviewed Feb 14, 2019
View reviewed changes
Comment thread src/udp_wrap.cc Outdated

addaleax commented Feb 15, 2019

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20806/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 15, 2019

antsmartian commented Feb 17, 2019

Copy link
Copy Markdown
Contributor

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20826/

addaleax commented Feb 17, 2019

Copy link
Copy Markdown
Member

Landed in 05292cb

addaleax closed this Feb 17, 2019
addaleax pushed a commit that referenced this pull request Feb 17, 2019
src: extract common sockaddr creation code
05292cb 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Feb 17, 2019
src: extract common sockaddr creation code
e13ce0f 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
danbev deleted the udp_sockaddr branch February 25, 2019 06:36
BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
src: extract common sockaddr creation code
f44f335 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
src: extract common sockaddr creation code
89dd890 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
src: extract common sockaddr creation code
57469e6 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs mentioned this pull request May 16, 2019
Merged
beevelop mentioned this pull request May 29, 2019
Closed
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL