FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix code lang in repl.md by gengjiawen · Pull Request #26075 · nodejs/node · GitHub

/ node Public

doc: fix code lang in repl.md - #26075

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:fix-repl-doc
ConversationCommits (1)ChecksFiles changed
Closed

doc: fix code lang in repl.md#26075
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:fix-repl-doc

Conversation

gengjiawen commented Feb 13, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem. labels Feb 13, 2019
vsemozhetbyt reviewed Feb 13, 2019
View reviewed changes
Comment thread doc/api/repl.md Outdated

richardlau commented Feb 13, 2019

Copy link
Copy Markdown
Member

There are other instances in this file of the repl being started from the command line (node ...) and they're currently using js. Either all of them should be changed for consistency or the instance being changed here left alone.

vsemozhetbyt commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

It seems they were marked as js so that code and outputted literals are js-highlighted.

gengjiawen commented Feb 14, 2019

Copy link
Copy Markdown
Member Author

It's not js actually. So better to change it.

lance reviewed Feb 14, 2019
View reviewed changes

lance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't understand how changing the code sections to bash is an improvement. It's not pure JavaScript since it's in the REPL, but it seems closer to JS than to bash, in my opinion. If we're going to be strict about it, I would say that in most code examples on this file, there should be no language specified.

gengjiawen commented Feb 14, 2019

Copy link
Copy Markdown
Member Author

Refactor it to console, inspired by https://stackoverflow.com/a/49004070/1713757.

danbev commented Feb 19, 2019

Copy link
Copy Markdown
Contributor

CI lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2664/

danbev commented Feb 19, 2019

Copy link
Copy Markdown
Contributor

Landed in a993160.

danbev closed this Feb 19, 2019
danbev pushed a commit that referenced this pull request Feb 19, 2019
doc: fix code lang in repl.md
a993160 
PR-URL: #26075
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 19, 2019
doc: fix code lang in repl.md
db9ec5a 
PR-URL: #26075
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
doc: fix code lang in repl.md
8fac54a 
PR-URL: #26075
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
vsemozhetbyt vsemozhetbyt left review comments
lance lance approved these changes
danbev danbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL