FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark,test: refactoring by refack · Pull Request #26119 · nodejs/node · GitHub

/ node Public

benchmark,test: refactoring - #26119

Merged
refack merged 1 commit into
nodejs:masterfrom
refack:http-benchmark-cleanup
Feb 18, 2019
ConversationCommits (1)ChecksFiles changed
Merged

benchmark,test: refactoring#26119
refack merged 1 commit into
nodejs:masterfrom
refack:http-benchmark-cleanup

Conversation

refack commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Mostly style changes.

  • sorting and minimizing the list of params in the sanity test harness.

Refs: #26101

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Feb 15, 2019

Copy link
Copy Markdown
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2615/pipeline

nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Feb 15, 2019
refack mentioned this pull request Feb 15, 2019
Merged
3 tasks

Trott commented Feb 15, 2019

Copy link
Copy Markdown
Member

Needs some lint fixes? LGTM otherwise.

refack force-pushed the http-benchmark-cleanup branch from 91d8158 to e3c83d5 Compare February 17, 2019 19:07

refack commented Feb 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Custom CI: https://ci.nodejs.org/job/node-test-commit-custom-suites/877/ ✔️

refack commented Feb 18, 2019

Copy link
Copy Markdown
Contributor Author

/CC @nodejs/benchmarking @nodejs/testing PTAL

refack self-assigned this Feb 18, 2019
benchmark,test: refactoring
c7b6a22 
PR-URL: nodejs#26119
Refs: nodejs#26101
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack force-pushed the http-benchmark-cleanup branch from e3c83d5 to c7b6a22 Compare February 18, 2019 18:16
refack merged commit c7b6a22 into nodejs:master Feb 18, 2019
refack deleted the http-benchmark-cleanup branch February 18, 2019 18:17
addaleax pushed a commit that referenced this pull request Feb 19, 2019
benchmark,test: refactoring
b50651f 
PR-URL: #26119
Refs: #26101
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
benchmark,test: refactoring
f4955fd 
PR-URL: #26119
Refs: #26101
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack removed their assignment Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL