FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

worker: type error on posting undefined/null message by legendecas · Pull Request #26123 · nodejs/node · GitHub

/ node Public

worker: type error on posting undefined/null message - #26123

Closed
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:worker-message
ConversationCommits (1)ChecksFiles changed
Closed

worker: type error on posting undefined/null message#26123
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:worker-message

Conversation

legendecas commented Feb 15, 2019

Copy link
Copy Markdown
Member

expecting close #26122

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the worker Issues and PRs related to Worker support. label Feb 15, 2019

legendecas commented Feb 15, 2019

Copy link
Copy Markdown
Member Author

@addaleax Hola, may I ask you to have a look? :P

lundibundi commented Feb 15, 2019

Copy link
Copy Markdown
Member

I think this is already addressed by https://github.com/nodejs/node/pull/26082/files#diff-758f6af0d3d1a219d6b5d63cd2e7cc14R65 PTAL.

Thanks for a swift fix anyway 👍

addaleax approved these changes Feb 15, 2019
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we could keep the test part here anyway? :)

lundibundi approved these changes Feb 15, 2019
View reviewed changes

lundibundi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

@addaleax Good idea.

lundibundi commented Feb 15, 2019

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20785/

lundibundi added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 15, 2019

legendecas commented Feb 17, 2019

Copy link
Copy Markdown
Member Author

Conflicts resolved. Now the PR contains tests only.

addaleax commented Feb 17, 2019

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/2083

legendecas commented Feb 17, 2019

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/2083

Looks like it failed for network issues?

addaleax commented Feb 17, 2019

Copy link
Copy Markdown
Member

Sorry, I posted a broken link. (Should have been https://ci.nodejs.org/job/node-test-pull-request/20831/.)

But anyway, it failed for unrelated reasons, so, resume CI: https://ci.nodejs.org/job/node-test-pull-request/20834/

addaleax commented Feb 17, 2019

Copy link
Copy Markdown
Member

Landed in c077c21, thanks for the PR! 🎉

addaleax closed this Feb 17, 2019
addaleax pushed a commit that referenced this pull request Feb 17, 2019
test,worker: posting undefined/null message to message port
c077c21 
Related: #26122

PR-URL: #26123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 17, 2019
test,worker: posting undefined/null message to message port
665d13b 
Related: #26122

PR-URL: #26123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
legendecas deleted the worker-message branch February 18, 2019 02:56
BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
test,worker: posting undefined/null message to message port
db94ab7 
Related: #26122

PR-URL: #26123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
lundibundi lundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. worker Issues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

worker: parentPort.postMessage fails on undefined value

6 participants

Back | FazBrowse Home | New Git URL