FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: clean unused macro in inspector_socket.cc by gengjiawen · Pull Request #26158 · nodejs/node · GitHub

/ node Public

src: clean unused macro in inspector_socket.cc - #26158

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:cleanup_unused_macro
Closed

src: clean unused macro in inspector_socket.cc#26158
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:cleanup_unused_macro

Conversation

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol labels Feb 17, 2019

Copy link
Copy Markdown
Member

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 20, 2019
gengjiawen mentioned this pull request Feb 27, 2019
2 tasks

danbev commented Feb 27, 2019

Copy link
Copy Markdown
Contributor

Landed in 8a273f1.

danbev closed this Feb 27, 2019
danbev pushed a commit that referenced this pull request Feb 27, 2019
PR-URL: #26158
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gengjiawen deleted the cleanup_unused_macro branch February 27, 2019 08:49
addaleax pushed a commit that referenced this pull request Mar 1, 2019
PR-URL: #26158
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR mentioned this pull request Mar 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL