FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: refactor tick objects prune function by asattelmaier · Pull Request #26163 · nodejs/node · GitHub

/ node Public

test: refactor tick objects prune function - #26163

Closed
asattelmaier wants to merge 2 commits into
nodejs:masterfrom
asattelmaier:test-refactor-verify-graph
Closed

test: refactor tick objects prune function#26163
asattelmaier wants to merge 2 commits into
nodejs:masterfrom
asattelmaier:test-refactor-verify-graph

Conversation

asattelmaier commented Feb 17, 2019
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • (not required) documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Feb 17, 2019

Copy link
Copy Markdown
Contributor Author

Just saw that I didn't create a new build for my latest local test run. I will fix it.

asattelmaier force-pushed the test-refactor-verify-graph branch from 88df726 to e760bc7 Compare February 17, 2019 20:11

Copy link
Copy Markdown
Member

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 20, 2019

addaleax commented Mar 1, 2019

Copy link
Copy Markdown
Member

Landed in e02453c, 8347dbe – thanks for the PR! 🎉

addaleax closed this Mar 1, 2019
addaleax pushed a commit that referenced this pull request Mar 1, 2019
PR-URL: #26163
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 1, 2019
PR-URL: #26163
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 1, 2019
PR-URL: #26163
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 1, 2019
PR-URL: #26163
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR mentioned this pull request Mar 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL