FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: simplify AliasedBuffer lifetime management by addaleax · Pull Request #26196 · nodejs/node · GitHub

/ node Public

src: simplify AliasedBuffer lifetime management - #26196

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:aliased-buffer-lifetime
ConversationCommits (1)ChecksFiles changed
Closed

src: simplify AliasedBuffer lifetime management#26196
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:aliased-buffer-lifetime

Conversation

addaleax commented Feb 18, 2019

Copy link
Copy Markdown
Member

Rely on the V8 garbage collector to take care of managing
the lifetime of the underlying memory of an AliasedBuffer.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

src: simplify AliasedBuffer lifetime management
0b02d4a 
Rely on the V8 garbage collector to take care of managing
the lifetime of the underlying memory of an `AliasedBuffer`.

nodejs-github-bot commented Feb 18, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2662/pipeline

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 18, 2019
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 19, 2019

addaleax commented Feb 19, 2019

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20881/

gengjiawen reviewed Feb 19, 2019
View reviewed changes
Comment thread src/aliased_buffer.h

// allocate new native buffer
NativeT* new_buffer = Calloc<NativeT>(new_capacity);
NativeT* new_buffer = static_cast<NativeT*>(ab->GetContents().Data());

gengjiawen Feb 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

auto here ?

https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html#cast-expressions

joyeecheung Feb 19, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We've made a decision about being explicit if the type is not too verbose: https://github.com/nodejs/node/blob/master/CPP_STYLE_GUIDE.md#using-auto

gengjiawen Feb 19, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

But in current codebase, it's already used this way

node/src/node_platform.cc

Line 235 in c70e853

auto platform_data = static_cast<PerIsolatePlatformData*>(handle->data);

gengjiawen Feb 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also used by v8 by default

node/deps/v8/.clang-tidy

Line 7 in 9b4bf7d

modernize-use-auto,

addaleax Feb 19, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@gengjiawen The example in node_platform.cc you’re referring to uses a more complex type – I would agree with using auto for that. Generally, we’re not being super consistent here, and we’ve had debates about this before. ;)

I think auto would be okay here too, because the static_cast makes things a bit more obvious, but I still think NativeT* is simple enough as a type to be kept this way.

(Basically, I agree with what the linked clang docs are saying, I just think NativeT* is short enough for me.)

gengjiawen Feb 19, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There is an option MinTypeNameLength, disscuss it's value to make auto rule more consistent ?
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html#options

addaleax Feb 20, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@gengjiawen It’s just my opinion, but my gut feeling would be something like 10 or 12 characters or so, and only to use auto when the type is obvious (e.g. from new Something() or when using a cast).

addaleax commented Feb 20, 2019

Copy link
Copy Markdown
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20924/

addaleax commented Feb 21, 2019

Copy link
Copy Markdown
Member Author

Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/20937/

addaleax commented Feb 21, 2019

Copy link
Copy Markdown
Member Author

Landed in d1011f6

addaleax closed this Feb 21, 2019
addaleax deleted the aliased-buffer-lifetime branch February 21, 2019 21:22
addaleax added a commit that referenced this pull request Feb 21, 2019
src: simplify AliasedBuffer lifetime management
d1011f6 
Rely on the V8 garbage collector to take care of managing
the lifetime of the underlying memory of an `AliasedBuffer`.

PR-URL: #26196
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Feb 25, 2019
src: simplify AliasedBuffer lifetime management
75c9705 
Rely on the V8 garbage collector to take care of managing
the lifetime of the underlying memory of an `AliasedBuffer`.

PR-URL: #26196
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
src: simplify AliasedBuffer lifetime management
7e26ca6 
Rely on the V8 garbage collector to take care of managing
the lifetime of the underlying memory of an `AliasedBuffer`.

PR-URL: #26196
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gengjiawen gengjiawen left review comments
joyeecheung joyeecheung approved these changes
jasnell jasnell approved these changes
JungMinu JungMinu approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL