FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove node-report/test-api.js by cjihrig · Pull Request #26219 · nodejs/node · GitHub

/ node Public

test: remove node-report/test-api.js - #26219

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:rm-test
Feb 22, 2019
ConversationCommits (1)ChecksFiles changed
Merged

test: remove node-report/test-api.js#26219
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:rm-test

Conversation

cjihrig commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

There does not appear to be any difference between this test and test/node-report/test-api-nohooks.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot commented Feb 20, 2019

Copy link
Copy Markdown
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2674/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 20, 2019

richardlau commented Feb 20, 2019

Copy link
Copy Markdown
Member

There does not appear to be any difference between this test and test/node-report/test-api-nohooks.js.

FTR they are slightly different in the standalone module (where the tests originate) but that difference is lost in core after the changes to the defaults (in core nothing is enabled by default but the standalone module does enable some triggers by default unless invoked via the API).

richardlau added the report Issues and PRs related to process.report. label Feb 20, 2019

cjihrig commented Feb 20, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20916/

EDIT: CI was green.

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 20, 2019
mhdawson approved these changes Feb 22, 2019
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

test: remove node-report/test-api.js
455b927 
There does not appear to be any difference between this test
and test/node-report/test-api-nohooks.js.

PR-URL: nodejs#26219
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
cjihrig merged commit 455b927 into nodejs:master Feb 22, 2019
cjihrig deleted the rm-test branch February 22, 2019 18:47
addaleax pushed a commit that referenced this pull request Feb 25, 2019
test: remove node-report/test-api.js
3446419 
There does not appear to be any difference between this test
and test/node-report/test-api-nohooks.js.

PR-URL: #26219
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
test: remove node-report/test-api.js
6f9a764 
There does not appear to be any difference between this test
and test/node-report/test-api-nohooks.js.

PR-URL: #26219
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
richardlau richardlau approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. report Issues and PRs related to process.report. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL