doc: add examples for tty.getColorDepth() env - #26248
Closed
BridgeAR wants to merge 5 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This adds some examples what values can be used to enforce a specific color support in Node.js.
Copy link
Copy Markdown
Collaborator
|
@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2695/pipeline |
Sorry, something went wrong.
Trott
reviewed
Feb 21, 2019
Comment thread
doc/api/tty.md
Outdated
Trott
reviewed
Feb 21, 2019
Comment thread
doc/api/tty.md
Outdated
Trott
reviewed
Feb 21, 2019
Comment thread
doc/api/tty.md
Outdated
Co-Authored-By: BridgeAR <ruben@bridgewater.de>
Co-Authored-By: BridgeAR <ruben@bridgewater.de>
Trott
approved these changes
Feb 21, 2019
starkwang
approved these changes
Feb 22, 2019
targos
reviewed
Feb 22, 2019
Comment thread
doc/api/tty.md
| This rule does not apply to Windows OS, CI environments, and some other rare | ||
| cases. | ||
|
|
||
| * 2 colors: `NODE_DISABLE_COLORS = 1` |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This works on Windows
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Good catch. I updated the comment again to reflect that. PTAL.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Hm... Hyper doesn't support 24 bit colors anymore and I used that in here as example. Therefore I consider doing something else instead of these examples as they could change over time without the change being reflected in the docs. |
Sorry, something went wrong.
4 tasks
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 19, 2019
This adds support to enforce a specific color depth by checking the `FORCE_COLOR` environment variable similar to `chalk`. On top of that we also add support for the `NO_COLOR` environment variable as suggested by https://no-color.org/. PR-URL: nodejs#26485 Refs: nodejs#26248 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
This adds support to enforce a specific color depth by checking the `FORCE_COLOR` environment variable similar to `chalk`. On top of that we also add support for the `NO_COLOR` environment variable as suggested by https://no-color.org/. PR-URL: nodejs#26485 Refs: nodejs#26248 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
This adds support to enforce a specific color depth by checking the `FORCE_COLOR` environment variable similar to `chalk`. On top of that we also add support for the `NO_COLOR` environment variable as suggested by https://no-color.org/. PR-URL: #26485 Refs: #26248 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some examples what values can be used to enforce a specific
color support in Node.js.
Checklist