doc: fix metadata of DEP0114 - #26250
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2697/pipeline |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Please add 👍 here to approve fast-tracking. |
Sorry, something went wrong.
BridgeAR
approved these changes
Feb 21, 2019
cjihrig
approved these changes
Feb 21, 2019
sam-github
approved these changes
Feb 21, 2019
Copy link
Copy Markdown
Member
Author
|
Fast-tracking has been approved. Thanks for reviewing, landed in 3d4db3a. |
Sorry, something went wrong.
tniessen
added a commit
that referenced
this pull request
Feb 22, 2019
PR-URL: #26250 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL was unknown before creating #25338 and I forgot to update the PR with the correct URL later.
Checklist