src: fix StreamPipe cleanup & interaction with env handles - #26256
Closed
addaleax wants to merge 2 commits into
Closed
src: fix StreamPipe cleanup & interaction with env handles#26256addaleax wants to merge 2 commits into
addaleax wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Do not access handles that have already begun to be closed or are closed.
In the presence of Workers, it is not safe to assume that `StreamPipe::Unpipe()` has been called at the time when the object is destroyed. Instead, clean up when the destructor is called.
Copy link
Copy Markdown
Collaborator
|
@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2703/pipeline |
Sorry, something went wrong.
joyeecheung
approved these changes
Feb 21, 2019
Comment thread
src/env.cc
| env->CloseHandle(handle, [](uv_handle_t* handle) {}); | ||
| env->CloseHandle(handle, [](uv_handle_t* handle) { | ||
| #ifdef DEBUG | ||
| memset(handle, 0xab, uv_handle_size(handle->type)); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
👍
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
addaleax
added a commit
that referenced
this pull request
Mar 1, 2019
Do not access handles that have already begun to be closed or are closed. PR-URL: #26256 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax
added a commit
that referenced
this pull request
Mar 1, 2019
In the presence of Workers, it is not safe to assume that `StreamPipe::Unpipe()` has been called at the time when the object is destroyed. Instead, clean up when the destructor is called. PR-URL: #26256 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax
added a commit
that referenced
this pull request
Mar 1, 2019
Do not access handles that have already begun to be closed or are closed. PR-URL: #26256 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax
added a commit
that referenced
this pull request
Mar 1, 2019
In the presence of Workers, it is not safe to assume that `StreamPipe::Unpipe()` has been called at the time when the object is destroyed. Instead, clean up when the destructor is called. PR-URL: #26256 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src: do not access Environment-owned handles after cleanup
Do not access handles that have already begun to be closed
or are closed.
src: clean up StreamPipe in destructor
In the presence of Workers, it is not safe to assume that
StreamPipe::Unpipe() has been called at the time when the object
is destroyed.
Instead, clean up when the destructor is called.
Checklist