test: simplify node-report/test-exception.js - #26277
Merged
cjihrig merged 1 commit intoFeb 26, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@cjihrig sadly an error occured when I tried to trigger a build :( |
Sorry, something went wrong.
jasnell
approved these changes
Feb 23, 2019
richardlau
reviewed
Feb 24, 2019
Comment thread
test/node-report/test-exception.js
Outdated
richardlau
approved these changes
Feb 24, 2019
Copy link
Copy Markdown
Member
👍 |
Sorry, something went wrong.
PR-URL: nodejs#26277 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
cjihrig
force-pushed
the
test-exception
branch
from
ac46966 to
c2b180f
Compare
February 26, 2019 23:15
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
PR-URL: #26277 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist