FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

report: simplify heap space iteration by cjihrig · Pull Request #26285 · nodejs/node · GitHub

/ node Public

report: simplify heap space iteration - #26285

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:loop
Feb 27, 2019
ConversationCommits (1)ChecksFiles changed
Merged

report: simplify heap space iteration#26285
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:loop

Conversation

cjihrig commented Feb 24, 2019

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Feb 24, 2019

Copy link
Copy Markdown
Collaborator

@cjihrig sadly an error occured when I tried to trigger a build :(

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 24, 2019
addaleax added the report Issues and PRs related to process.report. label Feb 24, 2019
report: simplify heap space iteration
084f74a 
PR-URL: nodejs#26285
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

cjihrig commented Feb 27, 2019

Copy link
Copy Markdown
Contributor Author

Yellow CI: https://ci.nodejs.org/job/node-test-pull-request/21011/

cjihrig merged commit 084f74a into nodejs:master Feb 27, 2019
cjihrig deleted the loop branch February 27, 2019 00:55
addaleax pushed a commit that referenced this pull request Mar 1, 2019
report: simplify heap space iteration
d2d9453 
PR-URL: #26285
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR mentioned this pull request Mar 4, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL