FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove already elevated Isolate namespace by juanarbol · Pull Request #26294 · nodejs/node · GitHub

/ node Public

src: remove already elevated Isolate namespace - #26294

Closed
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:cc-elevate-isolate
Closed

src: remove already elevated Isolate namespace#26294
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:cc-elevate-isolate

Conversation

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 24, 2019

addaleax commented Mar 2, 2019

Copy link
Copy Markdown
Member

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 2, 2019

Copy link
Copy Markdown
Contributor

Landed in 1d97374 🎉 Thanks @juanarbol 👍

antsmartian closed this Mar 3, 2019
antsmartian pushed a commit that referenced this pull request Mar 3, 2019
PR-URL: #26294
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 4, 2019
PR-URL: #26294
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR mentioned this pull request Mar 4, 2019
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
PR-URL: #26294
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs mentioned this pull request May 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL