test: eliminate port collision in test-cluster-net-listen-ipv6only-rr - #26298
Merged
gireeshpunathil merged 1 commit intoFeb 28, 2019
Merged
test: eliminate port collision in test-cluster-net-listen-ipv6only-rr#26298gireeshpunathil merged 1 commit into
gireeshpunathil merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@gireeshpunathil sadly an error occured when I tried to trigger a build :( |
Sorry, something went wrong.
Trott
reviewed
Feb 25, 2019
Comment thread
test/sequential/test-cluster-net-listen-ipv6only-rr.js
Outdated
Copy link
Copy Markdown
Member
|
Maybe add a comment explaining that it needs to be in sequential and have a static port and add a Refs link in the comment to this PR? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Needs a rebase. LGTM with the port replaced with common.PORT. |
Sorry, something went wrong.
gireeshpunathil
force-pushed
the
rr
branch
2 times, most recently
from
4abb32b to
a07b100
Compare
February 26, 2019 04:16
Copy link
Copy Markdown
Member
Author
|
@Trott - thanks. i) moved to common.PORT, ii) described change with comment, iii) rebased. ptal! |
Sorry, something went wrong.
Trott
approved these changes
Feb 26, 2019
Copy link
Copy Markdown
Member
Sorry, something went wrong.
cjihrig
approved these changes
Feb 26, 2019
BethGriggs
approved these changes
Feb 26, 2019
In test test-cluster-net-listen-ipv6only-rr, the cluster member that listens to `any` port actually has the potential to `grab` any port from the environment which when passed onto the master causes collision when it tries to listen on. Moving the test to sequential alone is not sufficient as the cluster member can in theory catch on to the admin ports on the host. Assigning static port alone is also not sufficient, as it can interfere with other running tests in the parallel category which would be mostly running with `port: any` fashion. So move to sequential, and use a static port. Fixes: nodejs#25813 PR-URL: nodejs#26298 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
In test test-cluster-net-listen-ipv6only-rr, the cluster member that listens to `any` port actually has the potential to `grab` any port from the environment which when passed onto the master causes collision when it tries to listen on. Moving the test to sequential alone is not sufficient as the cluster member can in theory catch on to the admin ports on the host. Assigning static port alone is also not sufficient, as it can interfere with other running tests in the parallel category which would be mostly running with `port: any` fashion. So move to sequential, and use a static port. Fixes: #25813 PR-URL: #26298 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In test test-cluster-net-listen-ipv6only-rr, the cluster member that
listens to any port actually has the potential to grab any port
from the environment which when passed onto the master causes
collision when it tries to listen on.
Moving the test to sequential alone is not sufficient as the cluster
member can in theory catch on to the admin ports on the host.
Assigning static port alone is also not sufficient, as it can interfere
with other running tests in the parallel category which would be mostly
running with port: any fashion.
So move to sequential, and use a static port.
Fixes: #25813
Checklist