doc: maxReservedRemoteStreams value constraints - #26309
Closed
sebdeckers wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@sebdeckers sadly an error occured when I tried to trigger a build :( |
Sorry, something went wrong.
jasnell
approved these changes
Feb 26, 2019
Trott
approved these changes
Feb 26, 2019
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mcollina
approved these changes
Feb 26, 2019
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
cjihrig
approved these changes
Feb 26, 2019
lpinca
approved these changes
Feb 26, 2019
Copy link
Copy Markdown
Member
FYI, I'm pretty sure that's just because CI is locked down right now while the upcoming security release is prepared. (Mentioning it only since @sebdeckers gave it a 😕 reaction.) |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Mar 2, 2019
PR-URL: #26309 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Mar 2, 2019
PR-URL: #26309 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source:
https://nghttp2.org/documentation/nghttp2_option_set_max_reserved_remote_streams.html
Checklist
/cc @nodejs/http2