FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix typo in callback.cc by gengjiawen · Pull Request #26337 · nodejs/node · GitHub

/ node Public

src: fix typo in callback.cc - #26337

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:callback_typo
Closed

src: fix typo in callback.cc#26337
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:callback_typo

Conversation

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 27, 2019

addaleax commented Mar 2, 2019

Copy link
Copy Markdown
Member

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 2, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 4, 2019
PR-URL: nodejs#26337
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR commented Mar 4, 2019

Copy link
Copy Markdown
Member

Landed in 5e23bac 🎉

BridgeAR closed this Mar 4, 2019
gengjiawen deleted the callback_typo branch March 4, 2019 02:26
BridgeAR pushed a commit that referenced this pull request Mar 4, 2019
PR-URL: #26337
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR mentioned this pull request Mar 4, 2019
BridgeAR pushed a commit that referenced this pull request Mar 5, 2019
PR-URL: #26337
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL