FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: document DoWrite() usage expectations by sam-github · Pull Request #26339 · nodejs/node · GitHub

/ node Public

src: document DoWrite() usage expectations - #26339

Closed
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:doc-dowrite-expectations
ConversationCommits (1)ChecksFiles changed
Closed

src: document DoWrite() usage expectations#26339
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:doc-dowrite-expectations

Conversation

sam-github commented Feb 27, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Clarify how it must behave for both synchronous and asynchronous
completion.

@addaleax @nodejs/streams This documents my understanding of the StreamResource::DoWrite() API expectations. TLS wasn't obeying these expecations, leading to wide-spread test suite failures during TLS1.3 development.

Checklist

src: document DoWrite() usage expectations
7b13a44 
Clarify how it must behave for both synchronous and asynchronous
completion.

nodejs-github-bot commented Feb 27, 2019

Copy link
Copy Markdown
Collaborator

@sam-github sadly an error occured when I tried to trigger a build :(

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 27, 2019
sam-github added the stream Issues and PRs related to the stream subsystem. label Feb 27, 2019

sam-github commented Feb 28, 2019

Copy link
Copy Markdown
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/21038/

mcollina approved these changes Feb 28, 2019
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

sam-github commented Feb 28, 2019

Copy link
Copy Markdown
Contributor Author

re-ci: https://ci.nodejs.org/job/node-test-commit/26192/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 28, 2019

sam-github commented Mar 2, 2019

Copy link
Copy Markdown
Contributor Author

re-ci: https://ci.nodejs.org/job/node-test-pull-request/21112/ It's just a header file comment, but a good build is hard to find. :-(

sam-github commented Mar 2, 2019

Copy link
Copy Markdown
Contributor Author

re-ci: https://ci.nodejs.org/job/node-test-pull-request/21115/

windows vs2017 failed across the board, looks like remotes couldn't get connected to, but perhaps I misread the log files

addaleax commented Mar 2, 2019

Copy link
Copy Markdown
Member

Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/25099/

BridgeAR commented Mar 4, 2019

Copy link
Copy Markdown
Member

This should not require a full CI run as it's a doc only change. Therefore this should be good to land without making sure all platforms are green.

sam-github commented Mar 4, 2019

Copy link
Copy Markdown
Contributor Author

Landed in 6593f77

sam-github closed this Mar 4, 2019
sam-github deleted the doc-dowrite-expectations branch March 4, 2019 18:26
sam-github added a commit that referenced this pull request Mar 4, 2019
src: document DoWrite() usage expectations
6593f77 
Clarify how it must behave for both synchronous and asynchronous
completion.

PR-URL: #26339
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
src: document DoWrite() usage expectations
61baa45 
Clarify how it must behave for both synchronous and asynchronous
completion.

PR-URL: nodejs#26339
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR mentioned this pull request Mar 13, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL