FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix more extra-semi warnings by nornagon · Pull Request #26340 · nodejs/node · GitHub

/ node Public

src: fix more extra-semi warnings - #26340

Closed
nornagon wants to merge 1 commit into
nodejs:masterfrom
nornagon:more-extra-semi
Closed

src: fix more extra-semi warnings#26340
nornagon wants to merge 1 commit into
nodejs:masterfrom
nornagon:more-extra-semi

Conversation

Copy link
Copy Markdown
Contributor

Follow-up to #26330. Fixes warnings emitted by -Wc++98-compat-extra-semi.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 27, 2019

addaleax commented Mar 2, 2019

Copy link
Copy Markdown
Member

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 2, 2019

BridgeAR commented Mar 5, 2019
edited
Loading

Copy link
Copy Markdown
Member

BridgeAR commented Mar 5, 2019

Copy link
Copy Markdown
Member

Landed in a132b8a 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 5, 2019
PR-URL: nodejs#26340
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR closed this Mar 5, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
PR-URL: nodejs#26340
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL