FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update babel-eslint to 10.0.1 by Trott · Pull Request #26347 · nodejs/node · GitHub

/ node Public

tools: update babel-eslint to 10.0.1 - #26347

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:update-babel
Closed

tools: update babel-eslint to 10.0.1#26347
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:update-babel

Conversation

Trott commented Feb 28, 2019
edited
Loading

Copy link
Copy Markdown
Member

Update babel-eslint to 10.0.1.

The version we ship with currently has some minor vulnerabilities in lodash in its dependency tree. This won't affect end users, of course, but it does generate noise in some auditing tools, and we should set a good example in the source code and not use versions of tools with known vulnerabilities.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Update babel-eslint to 10.0.1.

Copy link
Copy Markdown
Collaborator

@Trott sadly an error occured when I tried to trigger a build :(

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 28, 2019

Trott commented Feb 28, 2019

Copy link
Copy Markdown
Member Author

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 28, 2019

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

addaleax commented Mar 2, 2019

Copy link
Copy Markdown
Member

Landed in 536e062

addaleax closed this Mar 2, 2019
addaleax pushed a commit that referenced this pull request Mar 2, 2019
Update babel-eslint to 10.0.1.

PR-URL: #26347
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Mar 2, 2019
Update babel-eslint to 10.0.1.

PR-URL: #26347
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR mentioned this pull request Mar 4, 2019
Trott deleted the update-babel branch January 13, 2022 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL