FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: remove unneeded .gitignore entries by Trott · Pull Request #26370 · nodejs/node · GitHub

/ node Public

tools: remove unneeded .gitignore entries - #26370

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:eslintcache
ConversationCommits (1)ChecksFiles changed
Closed

tools: remove unneeded .gitignore entries#26370
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:eslintcache

Conversation

Trott commented Mar 1, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Mar 1, 2019

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2724/pipeline

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 1, 2019
cjihrig approved these changes Mar 1, 2019
View reviewed changes
Comment thread .gitignore Outdated

cjihrig Mar 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What is the reasoning for removing this one? I wouldn't expect everyone to have this in their own .gitignore.

refack Mar 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

IIUC they are all covered by
https://github.com/nodejs/node/blob/c45a9da926f8de50ae42be4e9cda52fe485435dc/.gitignore#L2

richardlau Mar 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

IIUC they are all covered by

node/.gitignore

Line 2 in c45a9da
.*

It would be nice if that was included in the commit message for anyone glancing through the commit history.

Trott Mar 1, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It would be nice if that was included in the commit message for anyone glancing through the commit history.

@richardlau I've updated the commit message to say:

Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

richardlau approved these changes Mar 1, 2019
View reviewed changes
Comment thread .gitignore Outdated

richardlau Mar 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

IIUC they are all covered by

node/.gitignore

Line 2 in c45a9da
.*

It would be nice if that was included in the commit message for anyone glancing through the commit history.

tools: remove unneeded .gitignore entries
b9f1338 
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

Trott commented Mar 2, 2019

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2738/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 2, 2019

Trott commented Mar 3, 2019

Copy link
Copy Markdown
Member Author

Landed in b97cd9b

Trott closed this Mar 3, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 3, 2019
tools: remove unneeded .gitignore entries
b97cd9b 
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

PR-URL: nodejs#26370
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 4, 2019
tools: remove unneeded .gitignore entries
6e9a7e1 
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

PR-URL: #26370
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR mentioned this pull request Mar 4, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
tools: remove unneeded .gitignore entries
d4a8769 
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

PR-URL: #26370
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Trott deleted the eslintcache branch January 13, 2022 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL