FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

repl: add replDefaults to customize the writer by BridgeAR · Pull Request #26375 · nodejs/node · GitHub

/ node Public

repl: add replDefaults to customize the writer - #26375

Closed
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:add-repl-options
ConversationCommits (2)ChecksFiles changed
Closed

repl: add replDefaults to customize the writer#26375
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:add-repl-options

Conversation

BridgeAR commented Mar 1, 2019

Copy link
Copy Markdown
Member

So far it was not possible to modify the inspection defaults used by
the REPL from the running instance itself. This introduces a new
property on util.inspect which is only used inside the REPL and which
allows to modify the used inspection defaults at any point of time.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

repl: add replDefaults to customize the writer
9abd104 
So far it was not possible to modify the inspection defaults used by
the REPL from the running instance itself. This introduces a new
property on `util.inspect` which is only used inside the REPL and which
allows to modify the used inspection defaults at any point of time.

nodejs-github-bot commented Mar 1, 2019

Copy link
Copy Markdown
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2727/pipeline

nodejs-github-bot added build Issues and PRs related to build files or the CI. repl Issues and PRs related to the REPL subsystem. labels Mar 1, 2019

BridgeAR commented Mar 3, 2019

Copy link
Copy Markdown
Member Author

@nodejs/repl @nodejs/util PTAL

BridgeAR commented Mar 5, 2019

Copy link
Copy Markdown
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/21209/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 5, 2019
vsemozhetbyt reviewed Mar 5, 2019
View reviewed changes
Comment thread doc/api/repl.md Outdated

BridgeAR commented Mar 5, 2019

Copy link
Copy Markdown
Member Author

@nodejs/repl @nodejs/util this could use some more reviews.

Trott reviewed Mar 6, 2019
View reviewed changes
Comment thread doc/api/repl.md Outdated

BridgeAR commented Mar 6, 2019

Copy link
Copy Markdown
Member Author

Comments addressed.

CI https://ci.nodejs.org/job/node-test-pull-request/21279/

danbev commented Mar 8, 2019

Copy link
Copy Markdown
Contributor

Landed in 82f8821.

danbev closed this Mar 8, 2019
danbev pushed a commit that referenced this pull request Mar 8, 2019
repl: add replDefaults to customize the writer
82f8821 
So far it was not possible to modify the inspection defaults used by
the REPL from the running instance itself. This introduces a new
property on `util.inspect` which is only used inside the REPL and which
allows to modify the used inspection defaults at any point of time.

PR-URL: #26375
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
repl: add replDefaults to customize the writer
20fdf89 
So far it was not possible to modify the inspection defaults used by
the REPL from the running instance itself. This introduces a new
property on `util.inspect` which is only used inside the REPL and which
allows to modify the used inspection defaults at any point of time.

PR-URL: nodejs#26375
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 13, 2019
BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR added a commit that referenced this pull request Mar 13, 2019
2019-03-14, Version 11.12.0 (Current)
589c1b6 
Notable Changes

* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    #26367
* crypto:
  * Add `KeyObject.asymmetricKeySize` (Patrick Gansterer)
    #26387
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    #26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) #26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) #26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    #26527
BridgeAR added a commit that referenced this pull request Mar 14, 2019
repl: add replDefaults to customize the writer
a0b1191 
So far it was not possible to modify the inspection defaults used by
the REPL from the running instance itself. This introduces a new
property on `util.inspect` which is only used inside the REPL and which
allows to modify the used inspection defaults at any point of time.

PR-URL: #26375
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
2019-03-14, Version 11.12.0 (Current)
cb1e0cb 
Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    #25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    #26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    #26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) #26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) #26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    #26527
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
2019-03-14, Version 11.12.0 (Current)
f83918b 
Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    nodejs#25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    nodejs#26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    nodejs#26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) nodejs#26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) nodejs#26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    nodejs#26527
BridgeAR added a commit that referenced this pull request Mar 14, 2019
2019-03-14, Version 11.12.0 (Current)
274f8ae 
Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    #25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    #26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    #26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) #26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) #26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    #26527
BridgeAR added a commit that referenced this pull request Mar 15, 2019
2019-03-15, Version 11.12.0 (Current)
a4ff9df 
Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    #25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    #26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    #26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) #26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) #26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    #26527
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 15, 2019
2019-03-15, Version 11.12.0 (Current)
969c63a 
Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    nodejs#25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    nodejs#26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    nodejs#26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) nodejs#26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) nodejs#26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    nodejs#26527
BridgeAR deleted the add-repl-options branch January 20, 2020 11:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
jasnell jasnell approved these changes
+1 more reviewer
vsemozhetbyt vsemozhetbyt left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. repl Issues and PRs related to the REPL subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL