tools: update node-lint-md-cli-rollup lockfile - #26393
Closed
Trott wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This includes an update for chownr from 1.0.1 to 1.1.1, which means a fix for the issue described in isaacs/chownr#14. While not a user-facing issue, it seems like a good idea to patch promptly anyway.
Update lint-md.js from updated rollup modules.
Copy link
Copy Markdown
Collaborator
|
@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2740/pipeline |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Changes to lint-md.js are a result of build process. That is not a file that gets manually edited. Might be slightly easier to review with whitespace changes hidden, although really it probably just gets rubber-stamp reviewed. |
Sorry, something went wrong.
BridgeAR
approved these changes
Mar 3, 2019
BridgeAR
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
refack
approved these changes
Mar 4, 2019
refack
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 4, 2019
This includes an update for chownr from 1.0.1 to 1.1.1, which means a fix for the issue described in isaacs/chownr#14. While not a user-facing issue, it seems like a good idea to patch promptly anyway. PR-URL: nodejs#26393 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 4, 2019
Update lint-md.js from updated rollup modules. PR-URL: nodejs#26393 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
This includes an update for chownr from 1.0.1 to 1.1.1, which means a fix for the issue described in isaacs/chownr#14. While not a user-facing issue, it seems like a good idea to patch promptly anyway. PR-URL: nodejs#26393 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
Update lint-md.js from updated rollup modules. PR-URL: nodejs#26393 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes an update for chownr from 1.0.1 to 1.1.1, which means a
fix for the issue described in
isaacs/chownr#14. While not a
user-facing issue and unlikely to be exploitable, it seems like a good idea to patch promptly anyway.
Also rebuild lint-md.js with the updated modules.
👍 here to fast-track.
Checklist