FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove unused variable in node_http2.cc by gengjiawen · Pull Request #26395 · nodejs/node · GitHub

/ node Public

src: remove unused variable in node_http2.cc - #26395

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:remove_unused_varibale_in_node_http2
Closed

src: remove unused variable in node_http2.cc#26395
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:remove_unused_varibale_in_node_http2

Conversation

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Mar 2, 2019

Copy link
Copy Markdown
Member Author

@addaleax Can you review this pr ? Thanks.

addaleax commented Mar 4, 2019

Copy link
Copy Markdown
Member

danbev commented Mar 6, 2019

Copy link
Copy Markdown
Contributor

Landed in 3770ab9.

danbev closed this Mar 6, 2019
danbev pushed a commit that referenced this pull request Mar 6, 2019
PR-URL: #26395
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
gengjiawen deleted the remove_unused_varibale_in_node_http2 branch March 6, 2019 09:14
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
PR-URL: nodejs#26395
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
PR-URL: #26395
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL