report: refactor configuration management - #26414
Merged
cjihrig merged 2 commits intoMar 5, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2750/pipeline |
Sorry, something went wrong.
richardlau
reviewed
Mar 3, 2019
Comment thread
doc/api/process.md
Outdated
Comment thread
test/report/test-report-config.js
Outdated
Comment thread
test/report/test-report-config.js
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@richardlau @jasnell nits addressed |
Sorry, something went wrong.
jasnell
reviewed
Mar 5, 2019
Comment thread
lib/internal/process/report.js
Outdated
richardlau
approved these changes
Mar 5, 2019
richardlau
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with one suggestion and once the test is fixed for Windows.
Sorry, something went wrong.
Comment thread
lib/internal/process/report.js
Outdated
Comment thread
test/report/test-report-config.js
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@richardlau @jasnell nits addressed (again) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
There are some C++ linter failures: https://travis-ci.com/nodejs/node/jobs/182405108#L457-L462 Running C++ linter... File "src/node_report_module.cc" does not use "FIXED_ONE_BYTE_STRING" File "src/node_report_module.cc" does not use "PerIsolateOptions" File "src/node_report_module.cc" does not use "Array" File "src/node_report_module.cc" does not use "V8" make[1]: *** [tools/.cpplintstamp] Error 1 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
OK, Travis seems to be happy now. |
Sorry, something went wrong.
richardlau
approved these changes
Mar 5, 2019
geek
approved these changes
Mar 5, 2019
This commit removes process.report.setOptions(). Instead of using complex configuration synchronization between C++ and JS, this commit introduces individual getters and setters. PR-URL: nodejs#26414 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reduce the number of emitExperimentalWarning() call sites by making process.report emit a warning on access instead of each individual report function. PR-URL: nodejs#26414 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Landed in c78788a...cc4e8e0. Thanks for the reviews! |
Sorry, something went wrong.
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
This commit removes process.report.setOptions(). Instead of using complex configuration synchronization between C++ and JS, this commit introduces individual getters and setters. PR-URL: nodejs#26414 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
Reduce the number of emitExperimentalWarning() call sites by making process.report emit a warning on access instead of each individual report function. PR-URL: nodejs#26414 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes process.report.setOptions(). Instead of using complex configuration synchronization between C++ and JS, this commit introduces individual getters and setters.
Checklist